Merge pull request #1040 from OmniSharp/pretty-json-print

pretty print JSON when logging requests/responses in STDIO server
OmniSharp · Dec 4, 2017 · 099a2c1 · 099a2c1
2 parents c10d140 + eb804d6
commit 099a2c1
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/src/OmniSharp.Stdio/Host.cs b/src/OmniSharp.Stdio/Host.cs
@@ -9,6 +9,7 @@
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.Logging;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
 using OmniSharp.Endpoint;
 using OmniSharp.Mef;
 using OmniSharp.Models.UpdateBuffer;
@@ -160,6 +161,11 @@ public void Start()
                         }
                         catch (Exception e)
                         {
+                            if (e is AggregateException aggregateEx)
+                            {
+                                e = aggregateEx.Flatten().InnerException;
+                            }
+
                             _writer.WriteLine(new EventPacket()
                             {
                                 Event = "error",
@@ -218,6 +224,11 @@ private async Task HandleRequest(string json, ILogger logger)
             }
             catch (Exception e)
             {
+                if (e is AggregateException aggregateEx)
+                {
+                    e = aggregateEx.Flatten().InnerException;
+                }
+
                 // updating the response object here so that the ResponseStream
                 // prints the latest state when being closed
                 response.Success = false;
@@ -241,7 +252,7 @@ void LogRequest(string json, ILogger logger)
             try
             {
                 builder.AppendLine("************ Request ************");
-                builder.Append(json);
+                builder.Append(JToken.Parse(json).ToString(Formatting.Indented));
                 logger.LogDebug(builder.ToString());
             }
             finally
@@ -256,7 +267,7 @@ void LogResponse(string json, ILogger logger)
             try
             {
                 builder.AppendLine("************  Response ************ ");
-                builder.Append(json);
+                builder.Append(JToken.Parse(json).ToString(Formatting.Indented));
                 logger.LogDebug(builder.ToString());
             }
             finally