Merge pull request #5 from Ometria/bugfix/invalid-product-data

Clear product instance to prevent data leak.
Ometria · Nov 26, 2019 · afbbc2e · afbbc2e
2 parents 7eee2a9 + 9b3b578
commit afbbc2e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 7 deletions.
diff --git a/Ometria_Magento_Extension.xml b/Ometria_Magento_Extension.xml
@@ -23,7 +23,7 @@ We don&apos;t just pull the right data together in one place, we also create ins
 Whether it&apos;s with our multi-dimension funnel analysis which flags up specific channels that may be under-performing, or our customer dashboard which spots channels that deliver customers with the best CLV, our &apos;actionable insights&apos; come ready to go.</description>
    <license>Open Source License (OSL)</license>
    <license_uri>http://opensource.org/licenses/osl-3.0.php</license_uri>
-   <version>1.1.10</version>
+   <version>1.1.11</version>
    <stability>stable</stability>
    <notes>Add more ways to work out if a product is in stock and saleable.</notes>
    <authors>

diff --git a/app/code/community/Ometria/AbandonedCarts/etc/config.xml b/app/code/community/Ometria/AbandonedCarts/etc/config.xml
@@ -2,7 +2,7 @@
 <config>
     <modules>
         <Ometria_AbandonedCarts>
-            <version>1.1.10</version>
+            <version>1.1.11</version>
         </Ometria_AbandonedCarts>
     </modules>
 
@@ -57,4 +57,4 @@
             </resources>
         </acl>
     </adminhtml>
-</config>
+</config>
diff --git a/app/code/community/Ometria/Api/Model/Api.php b/app/code/community/Ometria/Api/Model/Api.php
@@ -247,6 +247,8 @@ public function get_products($ids) {
                 $listings = $this->_resolveStoreListings($listings, $store_ids, $productMediaConfig);
                 $info['store_listings'] = $listings;
 
+                // Clear product instance to prevent data leak
+                $product->clearInstance();
             } catch(Exception $e){
                 $info = false;
             }
@@ -639,4 +641,4 @@ private function _getParentProductsMapping($product_ids){
 
         return $ret;
     }
-}
+}
diff --git a/app/code/community/Ometria/Api/etc/config.xml b/app/code/community/Ometria/Api/etc/config.xml
@@ -2,7 +2,7 @@
 <config>
     <modules>
         <Ometria_Api>
-            <version>1.1.10</version>
+            <version>1.1.11</version>
         </Ometria_Api>
     </modules>
 
@@ -31,4 +31,4 @@
             </modules>
         </suite>
     </phpunit>
-</config>
+</config>
diff --git a/app/code/community/Ometria/Core/etc/config.xml b/app/code/community/Ometria/Core/etc/config.xml
@@ -2,7 +2,7 @@
 <config>
     <modules>
         <Ometria_Core>
-            <version>1.1.10</version>
+            <version>1.1.11</version>
         </Ometria_Core>
     </modules>