Skip to content
This repository has been archived by the owner on Mar 2, 2021. It is now read-only.

Updated some hungarian translations in the periodic table. #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

varszegimarcell
Copy link

Hi!

I found your alternative firmware for the NumWorks calculator, and I find it very nice. I'm also happy about the hungarian language option, as I'm hungarian. However, I found some mistakes in the name of the elements, in the periodic table. Some element name lacked the translation completely, some was incorrect grammarly. I fixed these errors, that's why I opened this pull request.

I corrected the name of elements according to the name of the elements in hungarian language. (https://hu.wikipedia.org/wiki/K%C3%A9miai_elemek_peri%C3%B3dusos_rendszere)

Keep up the good work guys. ;)

Best regards
Marcell

Updated and corrected hungarian translations.
Fixed some grammar mistakes, and typing errors.
@RedGl0w
Copy link
Member

RedGl0w commented Mar 21, 2020

Thank you very much
Some characters aren't yet supported by epsilon, so it needs to be tested with my still open PR (numworks/epsilon#1359).
For these translations, we should also add them for the toolbox @quentinguidee ...
Thank you !

@varszegimarcell
Copy link
Author

Thank you very much
Some characters aren't yet supported by epsilon, so it needs to be tested with my still open PR (numworks/epsilon#1359).
For these translations, we should also add them for the toolbox @quentinguidee ...
Thank you !

How hard it would be to extend the character set of Epsilon? I hadn't buried myself that much in the source code.

In the first place, I don't get it why they didn't use UTF-8. They want to save space or what? As a frecnh company, I guess they mainly concentrating on Europe and US, and with UTF-8, they could easily represent any characters form any language in Europe.

I will look at the issue by myself, when I have some free time.

BTW, what happens when you use "illegal" characters?

@RedGl0w
Copy link
Member

RedGl0w commented Mar 22, 2020

In the first place, I don't get it why they didn't use UTF-8. They want to save space or what? As a frecnh company, I guess they mainly concentrating on Europe and US, and with UTF-8, they could easily represent any characters form any language in Europe.

They use utf8 (in ion/src/shared/unicode I think), but their font doesn't handle some characters

BTW, what happens when you use "illegal" characters?

We get some buggy characters (a X in a box)

@Omega-Numworks Omega-Numworks deleted a comment from RedGl0w Mar 22, 2020
@varszegimarcell
Copy link
Author

In the first place, I don't get it why they didn't use UTF-8. They want to save space or what? As a frecnh company, I guess they mainly concentrating on Europe and US, and with UTF-8, they could easily represent any characters form any language in Europe.

They use utf8 (in ion/src/shared/unicode I think), but their font doesn't handle some characters

Ohh, I get it now what's happening here. They use Unicode character coding, but the fontset doesn't include all the chars.

I will look into, how difficult it would be to extend this fontset, to get proper hungarian launguage support.

BTW, I tested my fork on the calculator, and indeed, I get the buggy squares.

@varszegimarcell
Copy link
Author

I've took quick look after the missing hungarian chars.

I began the investigation at Kandinsky, (all these stuff I'm talking about is located in kandinsky/fonts/) as this component is responsible for the graphics. My first suspect was the ttf font files, that they use for the calculator. After opening up the ttf-s with a font editior, I found out that these files contain the required chars.

I investigated "rasterizer.c" after that. This little C program generates a bitmap embeddable font, as well as a PNG image from the font files, so the calculator can draw out the characters, and the developer can view the images, I guess for debugging reasons. The rasterizer iterates through an array, called "CodePoints", definied in the "code_points.h", and renders the characters. The array contains the unicode character codes, that needed to be rendered.

Maybe, if I add the missing char codes to this array, the needed chars will be rendered out, and makes us able to use them?

@RedGl0w
Copy link
Member

RedGl0w commented Mar 22, 2020

Maybe, if I add the missing char codes to this array, the needed chars will be rendered out, and makes us able to use them?

I think that it should work

@varszegimarcell
Copy link
Author

varszegimarcell commented Mar 22, 2020

Maybe, if I add the missing char codes to this array, the needed chars will be rendered out, and makes us able to use them?

I think that it should work

I will test it out, but it will be a different fork. If I make any progress in this regard, I will open an another pull request, but on Omega.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants