Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve field length enforcement #19

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chrisb
Copy link

@chrisb chrisb commented Aug 11, 2015

Thanks for building Fixy!

This PR attempts to improve some issues we encountered with formatters.

Specifically:

  • Due to our inheritance pattern and formatter re-use, it was difficult to track down the specific fields that caused exceptions to arise from formatters, so we now salt the raised exception with some added context.
  • We then discovered a formatter that was returning a string longer than a given field's size constraint; when encountering this during record generation, raise an exception.
  • One of the tools we used to identify the issue was the debug HTML decorator. Changing the generated page's background-color CSS property to something other than the fields' background color allowed us to easily spot records that exceeded the record length.

Cheers! 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant