Merge pull request jhipster#25934 from mshima/role-form

fix 48 sonar bugs

generators/angular/templates/src/main/webapp/app/account/password-reset/finish/password-reset-finish.component.html.ejs

@@ -50,7 +50,7 @@
 
     @if (key() && !success()) {
       <div>
-        <form name="form" role="form" (ngSubmit)="finishReset()" [formGroup]="passwordForm">
+        <form name="form" (ngSubmit)="finishReset()" [formGroup]="passwordForm">
           <div class="mb-3">
             <label class="form-label" for="newPassword">__jhiTranslateTag__('global.form.newpassword.label')</label>
             <input

generators/angular/templates/src/main/webapp/app/account/password-reset/init/password-reset-init.component.html.ejs

@@ -27,7 +27,7 @@
       <div class="alert alert-warning">
         <span>__jhiTranslateTag__('reset.request.messages.info')</span>
       </div>
-      <form name="form" role="form" (ngSubmit)="requestReset()" [formGroup]="resetRequestForm">
+      <form name="form" (ngSubmit)="requestReset()" [formGroup]="resetRequestForm">
         <div class="mb-3">
           <label class="form-label" for="email">__jhiTranslateTag__('global.form.email.label')</label>
           <input

generators/angular/templates/src/main/webapp/app/account/password/password.component.html.ejs

@@ -32,7 +32,7 @@
       <div class="alert alert-danger">__jhiTranslateTag__('global.messages.error.dontmatch')</div>
     }
 
-      <form name="form" role="form" (ngSubmit)="changePassword()" [formGroup]="passwordForm">
+      <form name="form" (ngSubmit)="changePassword()" [formGroup]="passwordForm">
         <div class="mb-3">
           <label class="form-label" for="currentPassword">__jhiTranslateTag__('global.form.currentpassword.label')</label>
           <input

generators/angular/templates/src/main/webapp/app/account/register/register.component.html.ejs

@@ -46,7 +46,7 @@
   <div class="d-flex justify-content-center">
     <div class="col-md-8">
     @if (!success()) {
-      <form name="form" role="form" (ngSubmit)="register()" [formGroup]="registerForm">
+      <form name="form" (ngSubmit)="register()" [formGroup]="registerForm">
         <div class="mb-3">
           <label class="form-label" for="login">__jhiTranslateTag__('global.form.username.label')</label>
           <input

generators/angular/templates/src/main/webapp/app/account/settings/settings.component.html.ejs

@@ -30,7 +30,7 @@
       <<%= jhiPrefixDashed %>-alert-error></<%= jhiPrefixDashed %>-alert-error>
 
     @if (settingsForm.value.login) {
-      <form name="form" role="form" (ngSubmit)="save()" [formGroup]="settingsForm" novalidate>
+      <form name="form" (ngSubmit)="save()" [formGroup]="settingsForm" novalidate>
         <div class="mb-3">
           <label class="form-label" for="firstName">__jhiTranslateTag__('settings.form.firstname')</label>
           <input

generators/angular/templates/src/main/webapp/app/admin/user-management/update/user-management-update.component.html.ejs

@@ -18,7 +18,7 @@
 -%>
 <div class="d-flex justify-content-center">
   <div class="col-8">
-    <form name="editForm" role="form" novalidate (ngSubmit)="save()" [formGroup]="editForm">
+    <form name="editForm" novalidate (ngSubmit)="save()" [formGroup]="editForm">
       <h2 id="myUserLabel">__jhiTranslateTag__('userManagement.home.createOrEditLabel')</h2>
 
       <<%= jhiPrefixDashed %>-alert-error></<%= jhiPrefixDashed %>-alert-error>

generators/angular/templates/src/main/webapp/app/entities/_entityFolder_/update/_entityFile_-update.component.html.ejs

@@ -18,7 +18,7 @@
 -%>
 <div class="d-flex justify-content-center">
     <div class="col-8">
-        <form name="editForm" role="form" novalidate (ngSubmit)="save()" [formGroup]="editForm">
+        <form name="editForm" novalidate (ngSubmit)="save()" [formGroup]="editForm">
             <h2 id="<%= jhiPrefixDashed %>-<%= entityFileName %>-heading" data-cy="<%= entityClass %>CreateUpdateHeading">__jhiTranslateTag__('<%- i18nKeyPrefix %>.home.createOrEditLabel')</h2>
 
             <div>

generators/angular/templates/src/main/webapp/app/login/login.component.html.ejs

@@ -25,7 +25,7 @@
         data-cy="loginError"
       >__jhiTranslateTag__('login.messages.error.authentication')</div>
     }
-      <form class="form" role="form" (ngSubmit)="login()" [formGroup]="loginForm">
+      <form class="form" (ngSubmit)="login()" [formGroup]="loginForm">
         <div class="mb-3">
           <label class="username-label" for="username">__jhiTranslateTag__('global.form.username.label')</label>
           <input

generators/vue/templates/src/main/webapp/app/account/change-password/change-password.vue.ejs

@@ -19,7 +19,7 @@
                     The password and its confirmation do not match!
                 </div>
 
-                <form name="form" role="form" id="password-form" v-on:submit.prevent="changePassword()">
+                <form name="form" id="password-form" v-on:submit.prevent="changePassword()">
                     <div class="form-group">
                         <label class="form-control-label" for="currentPassword"
                             v-text="t$('global.form[\'currentpassword.label\']')">Current password</label>

generators/vue/templates/src/main/webapp/app/account/login-form/login-form.vue.ejs

@@ -7,7 +7,7 @@
         </b-alert>
       </div>
       <div class="col-md-8">
-        <b-form role="form" v-on:submit.prevent="doLogin()">
+        <b-form v-on:submit.prevent="doLogin()">
           <b-form-group v-bind:label="t$('global.form[\'username.label\']')" label-for="username">
             <b-form-input
               id="username"

generators/vue/templates/src/main/webapp/app/account/register/register.vue.ejs

@@ -25,7 +25,7 @@
         </div>
         <div class="row justify-content-center">
             <div class="col-md-8">
-                <form id="register-form" name="registerForm" role="form" v-on:submit.prevent="register()"
+                <form id="register-form" name="registerForm" v-on:submit.prevent="register()"
                     v-if="!success" no-validate>
                     <div class="form-group">
                         <label class="form-control-label" for="username"

generators/vue/templates/src/main/webapp/app/account/reset-password/finish/reset-password-finish.vue.ejs

@@ -30,7 +30,7 @@
                 </div>
 
                 <div v-if="!keyMissing">
-                    <form v-if="!success" name="form" role="form" v-on:submit.prevent="finishReset()">
+                    <form v-if="!success" name="form" v-on:submit.prevent="finishReset()">
                         <div class="form-group">
                             <label class="form-control-label" for="newPassword"
                                 v-text="t$('global.form[\'newpassword.label\']')">New password</label>

generators/vue/templates/src/main/webapp/app/account/reset-password/init/reset-password-init.vue.ejs

@@ -13,7 +13,7 @@
                         password.</p>
                 </div>
 
-                <form v-if="!success" name="form" role="form" v-on:submit.prevent="requestReset()">
+                <form v-if="!success" name="form" v-on:submit.prevent="requestReset()">
                     <div class="form-group">
                         <label class="form-control-label" for="email"
                             v-text="t$('global.form[\'email.label\']')">Email</label>

generators/vue/templates/src/main/webapp/app/account/settings/settings.vue.ejs

@@ -21,7 +21,7 @@
           <strong>Email is already in use!</strong> Please choose another one.
         </div>
 
-        <form name="form" id="settings-form" role="form" v-on:submit.prevent="save()" v-if="settingsAccount" novalidate>
+        <form name="form" id="settings-form" v-on:submit.prevent="save()" v-if="settingsAccount" novalidate>
           <div class="form-group">
             <label class="form-control-label" for="firstName" v-text="t$('settings.form.firstname')">First Name</label>
             <input type="text" class="form-control" id="firstName" name="firstName"

generators/vue/templates/src/main/webapp/app/admin/user-management/user-management-edit.vue.ejs

@@ -1,7 +1,7 @@
 <template>
   <div class="row justify-content-center">
     <div class="col-8">
-      <form name="editForm" role="form" novalidate v-on:submit.prevent="save()" v-if="userAccount">
+      <form name="editForm" novalidate v-on:submit.prevent="save()" v-if="userAccount">
         <h2 id="myUserLabel" v-text="t$('userManagement.home.createOrEditLabel')">
           Create or edit a User
         </h2>

generators/vue/templates/src/main/webapp/app/entities/_entityFolder_/_entityFile_-update.vue.ejs

@@ -1,7 +1,7 @@
 <template>
     <div class="row justify-content-center">
         <div class="col-8">
-            <form name="editForm" role="form" novalidate v-on:submit.prevent="save()" >
+            <form name="editForm" novalidate v-on:submit.prevent="save()" >
                 <h2 id="<%= i18nKeyPrefix %>.home.createOrEditLabel" data-cy="<%= entityClass %>CreateUpdateHeading" v-text="t$('<%= i18nKeyPrefix %>.home.createOrEditLabel')">Create or edit a <%= entityAngularName %></h2>
                 <div>
                     <div class="form-group" v-if="<%= entityInstance %>.<%= primaryKey.name %>">