Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up GitHub Actions and fix wrapper script #140

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Goooler
Copy link

@Goooler Goooler commented Jun 6, 2024

Validate builds for PRs and pushes on master.

Check the result at https://github.com/Goooler/Notally/actions/runs/9398823467/job/25884993374.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Goooler Goooler changed the title Add a GHA config to validate builds on CI and fix wrapper script Add a GHA config and fix wrapper script Jun 6, 2024
@OmGodse
Copy link
Owner

OmGodse commented Jun 8, 2024

What exactly is the point of this?

@Goooler
Copy link
Author

Goooler commented Jun 8, 2024

@Goooler Goooler changed the title Add a GHA config and fix wrapper script Set up GitHub Actions and fix wrapper script Jun 11, 2024
@clach04
Copy link

clach04 commented Jul 15, 2024

@Goooler I can see from your last Action (from June) https://github.com/Goooler/Notally/actions/runs/9398823467/job/25884993374 that this does a sanity check build (potentially useful for sanity checking PRs). Does this make test/installable APKs available?

@Goooler
Copy link
Author

Goooler commented Jul 15, 2024

That makes sure the assemble tasks pass, and we can upload the build artifacts as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants