Fixed issue #207 - Error Deserializing ChatMessage #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeecorleone
commented
May 9, 2024
| /// <summary> | ||
| /// Creates an empty <see cref="ImageInput"/> | ||
| /// </summary> | ||
| public ImageInput() { } |
There was a problem hiding this comment.
Added to support deserialization
zeecorleone
commented
May 9, 2024
| image = value; | ||
| text = null; | ||
| Type = "image_url"; | ||
| if (value != null) |
There was a problem hiding this comment.
After spending a lot of time, I found that this was the root cause. Values were being overwritten, hence deserialization was breaking. I tried to think of all cases/paths, and it looks fine to me to add this check. @OkGoDoIt , if you can think of anything where this doesn't fit it, let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #207.
(Important: PR 208 should be merged. The solution contains build errors inside Test project, which I fixed in that PR separately)