Arbitrum Stylus #170
Merged
Arbitrum Stylus #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Programs (copied from stylus repo)
Stylus Memory Model
Stylus master 6/20/22
Nitro master `ca73cbc`
Remove blockhash and difficulty from unit tests
Block benchmarks
* Change cost to per eighth of a kb * Add getter for call scalar
Stylus hostio timings
SDK Storage Tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| uint256 lastProvedLeafIdx = ~uint256(0); | ||
| bytes32 lastProvedLeafContents; |
Check warning
Code scanning / Slither
Uninitialized local variables Medium
src/challenge/ChallengeLib.sol
Outdated
| @@ -62,16 +64,21 @@ | |||
| ValueStack memory values = ValueStack({proved: valuesArray, remainingHash: 0}); | |||
| ValueStack memory internalStack; | |||
| StackFrameWindow memory frameStack; | |||
| MultiStack memory emptyMultiStack; | |||
Check warning
Code scanning / Slither
Uninitialized local variables Medium
Comment on lines
+433
to
+464
| function executeLinkModule( | ||
| ExecutionContext calldata, | ||
| Machine memory mach, | ||
| Module memory mod, | ||
| Instruction calldata, | ||
| bytes calldata proof | ||
| ) internal pure { | ||
| string memory prefix = "Module merkle tree:"; | ||
| bytes32 root = mach.modulesRoot; | ||
|
|
||
| uint256 pointer = mach.valueStack.pop().assumeI32(); | ||
| if (!mod.moduleMemory.isValidLeaf(pointer)) { | ||
| mach.status = MachineStatus.ERRORED; | ||
| return; | ||
| } | ||
| (bytes32 userMod, uint256 offset, ) = mod.moduleMemory.proveLeaf( | ||
| pointer / LEAF_SIZE, | ||
| proof, | ||
| 0 | ||
| ); | ||
|
|
||
| (uint256 leaf, , MerkleProof memory zeroProof) = proveLastLeaf(mach, offset, proof); | ||
|
|
||
| bool balanced = isPowerOfTwo(leaf + 1); | ||
| if (balanced) { | ||
| mach.modulesRoot = MerkleProofLib.growToNewRoot(root, leaf + 1, userMod, 0, prefix); | ||
| } else { | ||
| mach.modulesRoot = zeroProof.computeRootUnsafe(leaf + 1, userMod, prefix); | ||
| } | ||
|
|
||
| mach.valueStack.push(ValueLib.newI32(uint32(leaf + 1))); | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
Comment on lines
+572
to
+600
| function executeSwitchCoThread( | ||
| ExecutionContext calldata, | ||
| Machine memory mach, | ||
| Module memory, | ||
| Instruction calldata inst, | ||
| bytes calldata | ||
| ) internal pure { | ||
| if (mach.frameMultiStack.inactiveStackHash == MultiStackLib.NO_STACK_HASH) { | ||
| // cannot switch cothread if there isn't one | ||
| mach.status = MachineStatus.ERRORED; | ||
| return; | ||
| } | ||
| if (inst.argumentData == 0) { | ||
| if (mach.recoveryPc == MachineLib.NO_RECOVERY_PC) { | ||
| // switching to main thread, from main thread | ||
| mach.status = MachineStatus.ERRORED; | ||
| return; | ||
| } | ||
| mach.recoveryPc = MachineLib.NO_RECOVERY_PC; | ||
| } else { | ||
| if (mach.recoveryPc != MachineLib.NO_RECOVERY_PC) { | ||
| // switching from cothread to cothread | ||
| mach.status = MachineStatus.ERRORED; | ||
| return; | ||
| } | ||
| mach.setRecoveryFromPc(uint32(inst.argumentData)); | ||
| } | ||
| mach.switchCoThreadStacks(); | ||
| } |
Check warning
Code scanning / Slither
Unused return Medium
Add unit test for conditional OSP
Unique Module Hashes
eljobe
added a commit
to OffchainLabs/nitro
that referenced
this pull request
May 6, 2024
This is a temporary measure until OffchainLabs/nitro-contracts#170 is merged.
gzeoneth
approved these changes
May 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Arbitrum Stylus, which is slated to go live as part of ArbOS 30 pending DAO approval.