Fix storing the chain ids

OffchainLabs · Mar 27, 2024 · 03c3793 · 03c3793
1 parent 668fc09
commit 03c3793
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 8 deletions.
diff --git a/scripts/local-deployment/deployCreatorAndCreateRollup.ts b/scripts/local-deployment/deployCreatorAndCreateRollup.ts
@@ -22,6 +22,10 @@ async function main() {
     throw new Error('PARENT_CHAIN_RPC not set')
   }
 
+  if (!process.env.PARENT_CHAIN_ID) {
+    throw new Error('PARENT_CHAIN_ID not set')
+  }
+
   const deployerWallet = new ethers.Wallet(
     deployerPrivKey,
     new ethers.providers.JsonRpcProvider(parentChainRpc)

diff --git a/scripts/rollupCreation.ts b/scripts/rollupCreation.ts
@@ -201,7 +201,7 @@ export async function createRollup(
 
       const chainInfo: ChainInfo = {
         'chain-name': 'dev-chain',
-        'parent-chain-id': deployParams.config.chainId.toNumber(),
+        'parent-chain-id': +process.env.PARENT_CHAIN_ID!,
         'parent-chain-is-arbitrum': await _isRunningOnArbitrum(signer),
         'sequencer-url': '',
         'secondary-forwarding-target': '',
@@ -299,12 +299,6 @@ async function _getDevRollupConfig(feeToken: string) {
     }
   }
 
-  // set up parent chain id
-  let parentChainId =
-    process.env.PARENT_CHAIN_ID !== undefined
-      ? ethers.BigNumber.from(process.env.PARENT_CHAIN_ID)
-      : ethers.BigNumber.from(1337)
-
   return {
     config: {
       confirmPeriodBlocks: ethers.BigNumber.from('20'),
@@ -314,7 +308,7 @@ async function _getDevRollupConfig(feeToken: string) {
       wasmModuleRoot: wasmModuleRoot,
       owner: ownerAddress,
       loserStakeEscrow: ethers.constants.AddressZero,
-      chainId: parentChainId,
+      chainId: JSON.parse(chainConfig)['chainId'],
       chainConfig: chainConfig,
       genesisBlockNum: 0,
       sequencerInboxMaxTimeVariation: {