POC: Allow trust to be changed for a running tentacle without the need to restart #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -55,7 +59,7 @@ internal class TentacleConfiguration : ITentacleConfiguration | |||
| [Obsolete("This configuration entry is obsolete as of 3.0. It is only used as a Subscription ID where one does not exist.")] | |||
| public string? TentacleSquid => settings.Get("Octopus.Communications.Squid", (string?)null); | |||
|
|
|||
| public IEnumerable<OctopusServerConfiguration> TrustedOctopusServers => settings.Get<IEnumerable<OctopusServerConfiguration>>(TrustedServersSettingName) ?? new OctopusServerConfiguration[0]; | |||
| public IEnumerable<OctopusServerConfiguration> TrustedOctopusServers => changeDetectingSettings.Get<IEnumerable<OctopusServerConfiguration>>(TrustedServersSettingName) ?? Array.Empty<OctopusServerConfiguration>(); | |||
There was a problem hiding this comment.
TrustedOctopusServers will detect changes to the tentacle configuration so Trust changes do not require a restart of Tentacle
nathanwoctopusdeploy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Results
WIP POC
Before
After
How to review this PR
Quality ✔️
Pre-requisites