-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make integration test timeout configurable (for Windows Server 2012) #1006
Draft
samdanaei
wants to merge
34
commits into
main
Choose a base branch
from
sast/si/introduce-2012-timeout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samdanaei
force-pushed
the
sast/si/introduce-2012-timeout
branch
2 times, most recently
from
September 25, 2024 23:42
8efcfbb
to
60a1be0
Compare
samdanaei
changed the title
Just set the timeout to 10 minutes hardcoded for now. Can set through env variable later
Increase the timeout for Windows Server 2012
Sep 26, 2024
samdanaei
changed the title
Increase the timeout for Windows Server 2012
Make integration test timeout configurable (for Windows Server 2012)
Sep 26, 2024
samdanaei
force-pushed
the
sast/si/introduce-2012-timeout
branch
from
September 30, 2024 21:56
1af2f94
to
05e7646
Compare
samdanaei
force-pushed
the
sast/si/introduce-2012-timeout
branch
from
October 22, 2024 13:28
05e7646
to
3f4a297
Compare
…d ClientFileTransfersAreRetriedWhenRetriesAreEnabled.cs
This reverts commit 14ac994.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
On our Windows Server 2012 CI agents, we have observed some timeout and disk space issues that occur during certain test runs. We think these are caused by known issues with .NET 8 and Windows Server 2012, as these issues don't occur on any other operating system + .NET runtime combinations, for us.
As Microsoft won't be fixing the known issue, we have needed to deal with failures on our CI when we test tentacle functionality on Windows Server 2012.
Results
We are skipping some tests that may cause issues on our Windows 2012 CI build.
Why would we think that it's okay to skip these tests?
The skipped tests mainly test Tentacle functionality that
We see little risk in skipping these tests on Windows Server 2012 because most customers do not use the Operating System and we may be dropping support for it in the future.
How do we skip these tests on Windows 2012?
We introduced a new test attribute that allows us to read from an environment variable and skip tests based on that. We've introduced the
Has_NET8_Compatibility_Issues
environment variable and set it totrue
for the Windows Server 2012 CI build environment.If this PR is merged, we can reintroduce the Windows Server 2012 dependency to the build pipeline for some level of safety on the OS.
How to review this PR
Quality ✔️
Pre-requisites