Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integration test timeout configurable (for Windows Server 2012) #1006

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

samdanaei
Copy link
Contributor

@samdanaei samdanaei commented Sep 24, 2024

Background

On our Windows Server 2012 CI agents, we have observed some timeout and disk space issues that occur during certain test runs. We think these are caused by known issues with .NET 8 and Windows Server 2012, as these issues don't occur on any other operating system + .NET runtime combinations, for us.

As Microsoft won't be fixing the known issue, we have needed to deal with failures on our CI when we test tentacle functionality on Windows Server 2012.

Results

We are skipping some tests that may cause issues on our Windows 2012 CI build.

Why would we think that it's okay to skip these tests?

The skipped tests mainly test Tentacle functionality that

  • will not be used in a realistic environment by customers
  • can be proven to be working through other non-skipped tests working

We see little risk in skipping these tests on Windows Server 2012 because most customers do not use the Operating System and we may be dropping support for it in the future.

How do we skip these tests on Windows 2012?

We introduced a new test attribute that allows us to read from an environment variable and skip tests based on that. We've introduced the Has_NET8_Compatibility_Issues environment variable and set it to true for the Windows Server 2012 CI build environment.

If this PR is merged, we can reintroduce the Windows Server 2012 dependency to the build pipeline for some level of safety on the OS.

How to review this PR

Quality ✔️

Pre-requisites

  • I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
  • I have considered informing or consulting the right people, according to the ownership map.
  • I have considered appropriate testing for my change.

@samdanaei samdanaei force-pushed the sast/si/introduce-2012-timeout branch 2 times, most recently from 8efcfbb to 60a1be0 Compare September 25, 2024 23:42
@samdanaei samdanaei changed the title Just set the timeout to 10 minutes hardcoded for now. Can set through env variable later Increase the timeout for Windows Server 2012 Sep 26, 2024
@samdanaei samdanaei changed the title Increase the timeout for Windows Server 2012 Make integration test timeout configurable (for Windows Server 2012) Sep 26, 2024
@samdanaei samdanaei force-pushed the sast/si/introduce-2012-timeout branch from 1af2f94 to 05e7646 Compare September 30, 2024 21:56
@samdanaei samdanaei force-pushed the sast/si/introduce-2012-timeout branch from 05e7646 to 3f4a297 Compare October 22, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant