Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all isDisabled filter values when not filtering #883

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update all isDisabled filter values when not filtering #883

merged 1 commit into from
Oct 14, 2024

Conversation

grace-rehn
Copy link
Contributor

Fixes #882

The Octopus Server APIs will be updated to have the following logic:

  • isDisabled=true returns all disabled items
  • isDisabled=false returns all enabled items
  • isDisabled=null returns all items

Therefore having isDisabled=false as the base case when the filter is not being used is no longer correct.

Set isDisabled=null to get all items back.

Relates to:
OctopusDeployLabs/terraform-provider-octopusdeploy#624
OctopusDeploy/Issues#8916

@grace-rehn grace-rehn merged commit af53baa into master Oct 14, 2024
17 checks passed
@grace-rehn grace-rehn deleted the grace/update-isDisabled-filter-value branch October 14, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benPearce1 benPearce1 benPearce1 approved these changes

@hnrkndrssn hnrkndrssn Awaiting requested review from hnrkndrssn

@IsaacCalligeros95 IsaacCalligeros95 Awaiting requested review from IsaacCalligeros95

@HuyPhanNguyen HuyPhanNguyen Awaiting requested review from HuyPhanNguyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The isDisabled argument should default to null instead of false when filter is not used
2 participants
@grace-rehn @benPearce1