Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add TinyTypes to first stage ILMerge in build (#790)" #793

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

scme0
Copy link
Contributor

@scme0 scme0 commented Oct 30, 2023

This reverts commit 6bd94d5.

I've found that this seems to break things so I'm reverting it.

I get an error when I try to register tentacle using a TinyType:

Exception logging unhandled exception: 
System.TypeInitializationException: The type initializer for 'Octopus.Diagnostics.ExceptionExtensionMethods' threw an exception.
 ---> System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Could not load file or assembly 'Octopus.TinyTypes, Version=2.2.1008.0, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.

Could not load file or assembly 'Octopus.TinyTypes, Version=2.2.1008.0, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.

   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeAssembly.get_DefinedTypes()
   at Octopus.Diagnostics.ExceptionExtensionMethods.<>c.<.cctor>b__1_1(Assembly a)
   at System.Linq.Enumerable.SelectManySingleSelectorIterator`2.ToArray()
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Octopus.Diagnostics.ExceptionExtensionMethods..cctor()

@scme0 scme0 merged commit 45fd97e into master Oct 31, 2023
@scme0 scme0 deleted the scme/revert-changing-ilmerge branch October 31, 2023 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants