Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add username password account variables and control type #766

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Add username password account variables and control type #766

merged 5 commits into from
Oct 3, 2023

Conversation

susanpann
Copy link
Contributor

@susanpann susanpann commented Sep 25, 2023 •
edited
Loading

@susanpann susanpann marked this pull request as ready for review September 25, 2023 06:35
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #58725: Add ability to use username/password accounts as variables.

tothegills
tothegills reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@tothegills tothegills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UsernamePasswordAccount would better match the existing naming convention.

source/Octopus.Server.Client/Model/VariableType.cs Outdated Show resolved Hide resolved
@susanpann susanpann merged commit 0a34944 into master Oct 3, 2023
31 checks passed
@susanpann susanpann deleted the susan/newVariableType branch October 3, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothegills tothegills tothegills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susanpann @tothegills