add CICD #11
add CICD #11
Conversation
pelletier2017
force-pushed
the
setup_ci
branch
from
ec8cd6a
to
c7cb02b
Compare
pelletier2017
force-pushed
the
setup_ci
branch
from
a8310fc
to
15ef67f
Compare
.github/workflows/webhook.yml
Outdated
| @@ -0,0 +1,105 @@ | |||
| name: webhook-workflo | |||
There was a problem hiding this comment.
❓ Should this be webhook-workflow instead of webhook-workflo?
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| <properties> | |||
| <docker.registry>ghcr.io/octoconsulting</docker.registry> | |||
| <image-name>keip/${project.artifactId}</image-name> | |||
There was a problem hiding this comment.
❓ Do we need the version here?
There was a problem hiding this comment.
No because the version is at the top above properties and we set the tag for the image version here
<image>${docker.registry}/${image-name}</image>
<tags>
<tag>${project.version}</tag>
</tags>
| @@ -115,7 +116,7 @@ | |||
| </labels> | |||
| </container> | |||
| <to> | |||
| <image>${docker.registry}/keip/${project.artifactId}</image> | |||
| <image>${docker.registry}/${image-name}</image> | |||
There was a problem hiding this comment.
❓ Do we need the version here?
There was a problem hiding this comment.
Nope, the tag is added to the version. You can see it built and uploaded the correct image tag here.
https://github.com/OctoConsulting/keip/pkgs/container/keip%2Fminimal-app/176007969?tag=0.0.2
| prep-release: | ||
| rm -rf output | ||
| mkdir output | ||
| kustomize build ./controller > ./output/controller.yaml |
There was a problem hiding this comment.
❓ For the release, are we expecting to deliver to one yaml file or multiple as shown here?
There was a problem hiding this comment.
The release is made up of 3 files that are the output of kustomize build on those 3 directories. This follows the same pattern that metacontroller uses so people can include things separately as needed.
https://github.com/OctoConsulting/keip/releases/tag/operator_v0.1.0
Changes:
Artifacts are currently pushed up to view what they would look like. They will be deleted prior to merging.
Release details:
Right before merging:
Followup after PR: