fix typo #101
Merged
fix typo #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navarroc
reviewed
Jun 11, 2024
src/utils/format.ts
Outdated
| export const convertFahrenheitToCelcius = (temp: number): string => { | ||
| const formattedCelciusTemp = decimalFormat((temp - 32) * (5 / 9)); | ||
| return formattedCelciusTemp; | ||
| export const convertFahrenheitTosius = (temp: number): string => { |
There was a problem hiding this comment.
Typo here, should be I think convertFahrenheitToCelsius
There was a problem hiding this comment.
This is weird, this didn't comeup when I searched for celcius ... it seems the search was case sensitive... let me correct this...
There was a problem hiding this comment.
ahh I think I omitted out 'Cel' ... :P
|
Is there a way to deploy this on dev so we can verify the fix? |
|
This change looks good, but it would be good to test it out on dev before we merge and make a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typo in the word
Celsius