Mkonda/cleanup.2018.10 #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerlh
requested changes
Oct 14, 2018
| require 'pathname' | ||
|
|
||
| # This was written live during AppSecUSA 2018. | ||
| class Glue::SafetyCheck < Glue::BaseTask |
| require 'glue/util' | ||
| require 'pathname' | ||
|
|
||
| # This was written live during AppSecUSA 2018. |
| parsed = JSON.parse(results) | ||
| parsed.each do |item| | ||
| source = { :scanner => @name, :file => "#{item[0]} #{item[2]} from #{@trigger.path}/requirements.txt", :line => nil, :code => nil } | ||
| report "Library #{item[0]} has known vulnerabilities.", item[3], source, severity("medium"), fingerprint(item[3]) |
There was a problem hiding this comment.
There is no way to get the severity?
| report "Library #{item[0]} has known vulnerabilities.", item[3], source, severity("medium"), fingerprint(item[3]) | ||
| end | ||
| rescue Exception => e | ||
| Glue.warn e.message |
There was a problem hiding this comment.
Isn't this should be fatal? The task results parsing failed, the report is not completed...
| list = result.split(/\n/) | ||
| list.each do |result| | ||
| if result =~ /^Warning:/ | ||
| Glue.warn "Problem: #{result}" |
There was a problem hiding this comment.
I think this also should be fatal
|
Also added k8s example - maybe add something to the documentation folder? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies to current.
(This matters a lot for brakeman etc. but also eliminates vulnerabilities)
Add Omer and others to authors.
Remove version #'s from integration examples.