Add changeset map #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajithranka
reviewed
Apr 24, 2017
public/index.html
Outdated
| @@ -6,6 +6,8 @@ | |||
| <meta name="viewport" content="width=device-width, initial-scale=1"> | |||
| <link rel="shortcut icon" href="%PUBLIC_URL%/favicon.ico"> | |||
| <link href="https://api.mapbox.com/mapbox-assembly/v0.12.0/assembly.min.css" rel="stylesheet"> | |||
| <link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/animate.css/3.5.2/animate.min.css"> | |||
There was a problem hiding this comment.
Hey, if possible can we pull this in from the component?
ajithranka
reviewed
Apr 24, 2017
src/utils/key_bindings.js
Outdated
| @@ -0,0 +1 @@ | |||
| export function initKeyGobal() {} | |||
ajithranka
reviewed
Apr 24, 2017
src/app.js
Outdated
| if (document && document.body) { | ||
| document.body.addEventListener('showToast', this.showToast); | ||
| } | ||
| initKeyGobal(); |
ajithranka
reviewed
Apr 24, 2017
src/app.js
Outdated
| > | ||
| <Route exact path="/" component={Changeset} /> | ||
| <Route exact path="/" component={Changeset} customProp="hi" /> |
There was a problem hiding this comment.
Cleanup: customProp="hi".
ajithranka
reviewed
Apr 24, 2017
| <div> | ||
| <Header | ||
| changesetId={changesetId} | ||
| date={properties.get('date')} |
ajithranka
reviewed
Apr 24, 2017
src/components/filters.js
Outdated
| import {Tooltip} from 'react-tippy'; | ||
|
|
||
| class Filter extends React.PureComponent { | ||
| showForm = () => { |
# Conflicts: # src/store/index.js
|
@ajithranka you are good to merge this. |
|
Thanks @kepta! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a bunch of things
cc @ajithranka