Test suite: check that we can generate binary identical files compared to "golden" files #11194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tical to the expected golden file.
…cal to the expected golden file.
…cal to the expected golden file.
…-identical to the expected golden file.
…ical to the expected golden file.
…-identical to the expected golden file.
…tical to the expected golden file.
rouault
added
test suite
funded through GSP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test suite mostly checks that the read side of a driver can read what the write side has written. This is a good start, but this might not be able to detect potential regressions where we would write something non conformant that the read side of the driver would be tolerant about. So for a few popular formats, currently GTiff, COG, GPKG, OpenFileGDB, shapefile, JPEG2000 (through openjpeg) and netCDF (only V3), and under controlled conditions, add such basic checks. This is far from being complete, as such tests could be very fragile to maintain in case of slightly different output according to software versions of our dependencies...