Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve build issues of GDAL v3.9.3 in Windows and Linux using CMake #11117

Closed
wants to merge 639 commits into from

Conversation

psharma-gdal
Copy link

What does this PR do?

Allows to build GDAL v3.9.3 on Windows and Linux using CMake

  • CMakeLists.txt has changes to build GDAL v3.9.3 in Windows and Linux. It defines PROJ_DLL as an empty string for static linking. Also, it defines flags for including EXPAT as static lib
    -FindGEOS.cmake provides the capability to specify geos_c library as well to prevent linker errors in Windows
    -FindMRSID.cmake provides the flags yp specify MrSID and MrSID_LIDAR library and includes
    -FindWebP.cmake allows to specify LIBSHARPYUV to avoid linker errors in Linux

Environment

Windows and Linux

Provide environment details, if relevant:

  • OS: Windows/Visual Studio 2022
    Linux CentOS7

  • Compiler:
    Visual Studio 2022
    gcc8.3

rouault and others added 30 commits June 22, 2024 18:45
[Backport release/3.9] Various undefined behavior sanitizer fixes
[Backport release/3.9] OGR SQL: fix crash when the ON expression of a JOIN contains OGR special fields (in particular feature id)
…OSGeo#10308)

* update links in `generate_leaflet()`

* remove OSM Toner (Fixes OSGeo#10304)
Use OpenStreetMap's preferred tile url per: openstreetmap/operations#737
[Backport release/3.9] Use correct OpenStreetMap tile url in gdal2tiles.py generated HTML
[Backport release/3.9] LIBKML: fix writing a .kmz to cloud storage
[Backport release/3.9] Fix compilation against openssl-libs-3.2.2-3 of fedora:rawhide
…trix limits, if the dataset extent goes beyond them
[Backport release/3.9] WMTS: clip layer extent with union of extent of tile matrices
…oordinate is outside raster extent (3.9.0 regression)

Fixes OSGeo#10336
…(3.9.1 regression)

Fixes OSGeo#10332

Was caused by the fix 3674ec7 for OSGeo#10071

The regression mostly occurs when writing a GML file using ogr2ogr when
the source layer has a named geometry column, e.g if the source is a
GeoPackage or if using -sql
The problem was acutally latent and also could have occured before 3.9.1 if using
CreateLayer() without a SRS + CreateGeomField()
… if the output driver supports it (and the burned field is Int64)
…/3.9

[Backport 3.9]  Fix issues with gdalbuildvrt and gdalwarp regarding src/dst/vrtnodata arguments and negative values (3.9.0 regression)
rouault and others added 29 commits September 30, 2024 23:24
[Backport release/3.9] Warper: fix too lax heuristics about antimeridian warping for Avg/Sum/Q1/Q3/Mode algorithms
[Backport release/3.9] PDF: avoid 'Non closed ring detected' warning when reading neatlines from OGC Best Practice encoding
… DIMAP2 GeoTIFF file with external overviews
This has become unreliable lately with failures like in
https://github.com/OSGeo/gdal/actions/runs/10930480309/job/30377732865?pr=10840

```
+ docker exec -t gdal-sql1 /opt/mssql-tools/bin/sqlcmd -l 30 -S localhost -U SA -P DummyPassw0rd -Q CREATE DATABASE TestDB
Error response from daemon: container fba0406fd45fd855feea4090a0b46c321d70c1b4e000ba318ff1045c400d1b43 is not running
```

Although I can't reproduce the error locally
[Backport release/3.9] [doc] fix link to GDAL sponsorship prospectus
[Backport release/3.9] CPLGetValueType(): do not recognize '01' as integer, but as string
…views

Fixes OSGeo#10873

Uniformize logic with the one of GDALBandGetBestOverviewLevel2()
[Backport release/3.9] gdalwarp: be more robust to numerical instability when selecting overviews
[Backport release/3.9] PG/PGDump: properly truncates identifiers exactly of 64 characters
[Backport release/3.9] Python bindings: fix passing a dict value to the transformerOptions argument of gdal.Warp()
[Backport release/3.9] PG: ensure current user has superuser priviledge beore attemption to create event trigger for metadata table
[Backport release/3.9] DIMAP: emit verbose error message if not able to open image file
The -q parameter to wget makes it completely
silent, even on faliure which gives build errors
that are difficult to diagnose. Someone
else had the same problem 15 years ago:

https://serverfault.com/questions/70889/wget-to-print-errors-but-nothing-otherwise

and the easiest way to robustly print
errors but nothing else seems to be
to use curl instead.

Since the docker images already include
curl, switch them to use that instead.
…PEG2000 QUALITY

when JPEG2000_DRIVER=JP2OpenJPEG

Fixes OSGeo#10927
[Backport release/3.9] NITF: fix parsing of CSCSDB DES
CMake script changes to build GDAL v3.9.3 in Windows and Linux. Geos in windows needs both geos.lib and geos_c.lib in linker input. MrSID needs options to specify both MrSID and MrSID_LIDAR libs and include dirs. WebP needs to link with sharpyuv libs .  CMakelists.txt has changes to get rid of HDF5 linker errors and Expat link issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.