JP2Lura: fix Identify() method #11098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered accidentally the method was mis-identifying a EXR dataset as recognized by the JP2Lura driver while investigating OSGeo#11095. This dates back to 2e650d8 where for some reason (I suspect wrong copy&paste) the Identify() logic was completely changed
elpaso
approved these changes
Oct 24, 2024
|
A test would be nice to have so that we don't break it in the future. |
well, there's actually a test file for the JP2Lura, but it is entirely skipped on CI or even on my local machine because I no longer have access to the licensing key of the SDK. |
rouault
added
the
funded through GSP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered accidentally the method was mis-identifying a EXR dataset as recognized by the JP2Lura driver while investigating #11095. This dates back to 2e650d8 where for some reason (I suspect wrong copy&paste) the Identify() logic was completely changed