Added configuration to enable/disable maintenance with Puppet #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
reviewed
Jan 13, 2025
manifests/config.pp
Outdated
Comment on lines
97
to
102
| if $openondemand::maintenance_enabled != undef { | ||
| if $openondemand::maintenance_enabled { | ||
| $maintenance_enable_ensure = 'file' | ||
| } else { | ||
| $maintenance_enable_ensure = 'absent' | ||
| } |
There was a problem hiding this comment.
Suggested change
| if $openondemand::maintenance_enabled != undef { | |
| if $openondemand::maintenance_enabled { | |
| $maintenance_enable_ensure = 'file' | |
| } else { | |
| $maintenance_enable_ensure = 'absent' | |
| } | |
| if $openondemand::maintenance_enabled { | |
| $maintenance_enable_ensure = 'file' | |
| } else { | |
| $maintenance_enable_ensure = 'absent' | |
| } |
If it goes from enabled=true to undef the file won't get removed, so probably better to that undef or false will remove the file and true will create the file.
There was a problem hiding this comment.
OK, I have updated.
I did the check for undef for installations that are managing the maintenance.enable file manually and upgrading to the new puppet version will delete the file automatically if available after the upgrade.
I thought that changing from true to undef and the file not being deleted will be easier to spot and fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we manage all the OOD configuration and deployments with Puppet, we would like to enable/disable maintenance mode using a Puppet deployment.
This PR adds a new file resource to manage the
maintenace.enablefile.I am using undef to make it backwards compatible with institutions managing this file manually.