Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ondemand-dex package var name #234

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

i-mtz
Copy link
Contributor

@i-mtz i-mtz commented Mar 15, 2024

Current version of the role fails if you have install_ondemand_dex set to true as in

name: "{{ 'ondemand-dex' if ondemand_dex_package == 'latest' else ondemand-dex }}"
there is an non valid and undefined variable name ondemand-dex instead of ondemand_dex_package.
In this case the role fails:

TASK [osc.open_ondemand : Install ondemand-dex] *****************************************************************************************************************************************************************************************************************************************
fatal: [ood-ubuntu-devel.scicore.unibas.ch]: FAILED! => 
  msg: |-
    The task includes an option with an undefined variable. The error was: 'ondemand' is undefined. 'ondemand' is undefined
  
    The error appears to be in '/home/martin0009/ansible/playbooks/playbook-scicore-int/roles/osc.open_ondemand/tasks/install-package.yml': line 100, column 3, but may
    be elsewhere in the file depending on the exact syntax problem.
  
    The offending line appears to be:
  
  
    - name: Install ondemand-dex
      ^ here

Fixes #235

Copy link
Collaborator

@johrstrom johrstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@johrstrom johrstrom merged commit d6a9a1c into OSC:master Mar 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong var name for ondemand-dex causes playbook to fail
2 participants