Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessibility for interactive session cards #4061

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ahmed-mgd
Copy link
Contributor

Fixes #664

  • Announce status changes to screen reader
  • Restore focus to elements when cards refresh

@ahmed-mgd ahmed-mgd marked this pull request as ready for review January 13, 2025 19:30
@johrstrom
Copy link
Contributor

Seems like since you refactored to data attributes in 72d04c2 I think you can get rid of a lot of other updates you made around adding IDs to different elements.

@ahmed-mgd
Copy link
Contributor Author

Seems like since you refactored to data attributes in 72d04c2 I think you can get rid of a lot of other updates you made around adding IDs to different elements.

I believe pretty much all of the IDs were for the "refocusing" piece when the cards refresh, aside from the 'card_title" class which I'll get rid of. And perhaps I could also remove the <%= session.id %> suffix from each of the IDs, such as in

id: "delete_button_#{session.id}"

Either way, do you think there's a better way of querying for the elements we want to refocus on? I might have a blindspot on this.

@johrstrom
Copy link
Contributor

And perhaps I could also remove the <%= session.id %> suffix from each of the IDs, such as in

id: "delete_button_#{session.id}"

Yes this is what I meant. They're not needed if you're querying based on data attributes of the parent.

@ahmed-mgd ahmed-mgd marked this pull request as draft January 28, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interactive sessions cards not very accessable
3 participants