-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve accessibility for interactive session cards #4061
base: master
Are you sure you want to change the base?
Conversation
Seems like since you refactored to data attributes in 72d04c2 I think you can get rid of a lot of other updates you made around adding IDs to different elements. |
I believe pretty much all of the IDs were for the "refocusing" piece when the cards refresh, aside from the 'card_title" class which I'll get rid of. And perhaps I could also remove the
Either way, do you think there's a better way of querying for the elements we want to refocus on? I might have a blindspot on this. |
Yes this is what I meant. They're not needed if you're querying based on data attributes of the parent. |
Fixes #664