Docs for opm common and embedded #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hakonhagland can you have a look? Thanks! |
lisajulia
force-pushed
the
docs-for-opm-common-and-embedded
branch
from
7cfc36a
to
80c0eb0
Compare
lisajulia
force-pushed
the
docs-for-opm-common-and-embedded
branch
from
80c0eb0
to
69c9c34
Compare
|
@lisajulia Great, I will have a look later today 😄 |
hakonhagland
requested changes
Jun 17, 2024
| set(DOCSTRINGS_GENERATED_HEADER_PATH "${PROJECT_BINARY_DIR}/${TEMP_GEN_DIR}/${DOCSTRINGS_GENERATED_HPP}") | ||
| set(PYBLACKOIL_DOCSTRINGS_FILE "${PROJECT_SOURCE_DIR}/docs/docstrings_simulators.json") | ||
| set(PYBLACKOIL_DOCSTRINGS_GENERATED_HPP "PyBlackOilSimulatorDoc.hpp") | ||
| set(PYBLACKOIL_DOCSTRINGS_GENERATED_HEADER_PATH "${PROJECT_BINARY_DIR}/${TEMP_GEN_DIR}/${PYBLACKOIL_DOCSTRINGS_GENERATED_HPP}") |
There was a problem hiding this comment.
In this file, only PYBLACKOIL_DOCSTRINGS_GENERATED_HEADER_PATH and COMMON_DOCSTRINGS_GENERATED_HEADER_PATH needs to be exported to the global scope, right? I like to export only necessary variables, I think it helps with maintenance in the long run. Could we make this a function like in e.g. OpmPythonSetupInstall.cmake ? I realize this was something I forgot to do in the original version of this file..
|
|
||
| In order to enable the PYACTION keyword: | ||
|
|
||
| 1. OPM flow must be compiled with the cmake switches -DOPM ENABLE EMBEDDED PYTHON=ON and -DOPM ENABLE PYTHON=ON, the default is to build with these switches set to OFF. |
There was a problem hiding this comment.
The plan is to remove the -DOPM_ENABLE_PYTHON flag from opm-common and only keep the -DOPM ENABLE EMBEDDED PYTHON flag. When that is done, we should update this sentence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes from OPM/opm-common#4018 and OPM/opm-simulators#5349