Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plat-k3: Add locks for TI-SCI protocol #7089

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

plat-k3: Add locks for TI-SCI protocol #7089

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b7f2b2
plat-k3: drivers: Add mutex lock for ti_sci_do_xfer
manorit2001 Oct 8, 2024
5336f69
plat-k3: drivers: Move message_sequence updates inside ti_sci_do_xfer
manorit2001 Oct 29, 2024
2886a65
plat-k3: drivers: Refactor to ti_sci_send_request
manorit2001 Oct 30, 2024
58cf0c1
plat-k3: drivers: Add some trace message for TI-SCI calls
manorit2001 Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/arch/arm/plat-k3/drivers/ti_sci.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ static inline int ti_sci_send_request(struct ti_sci_xfer *xfer)
hdr = (struct ti_sci_msg_hdr *)msg->buf;
hdr->seq = ++message_sequence;

FMSG("Sending %x with seq %u host %u", msg->type, msg->seq, msg->host);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type is uint16_t, seq and host are uint8_t, hence use PRIu16 and PRIu8. Ditto at line 146.

	FMSG("Sending %#"PRIx16" with seq %"PRIu8" host %"PRIu8,
	     msg->type, msg->seq, msg->host);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original line doesn't even compile.. Building with CFG_TEE_CORE_LOG_LEVEL=4 shows that. type, seq, and host are members of hdr, not msg.


/* Send the message */
return k3_sec_proxy_send(msg);
}
Expand Down Expand Up @@ -141,6 +143,8 @@ static inline int ti_sci_get_response(struct ti_sci_xfer *xfer)
return TEE_ERROR_ACCESS_DENIED;
}

FMSG("Receive %x with seq %u host %u", msg->type, msg->seq, msg->host);

return 0;
}

Expand Down
Loading