-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rk3588 support #7056
base: master
Are you sure you want to change the base?
add rk3588 support #7056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some description to the commit and also your Signed-off-by:
. And see my comment below. Thanks!
@@ -85,6 +85,25 @@ | |||
#define FIREWALL_DDR_BASE 0xff534000 | |||
#define FIREWALL_DDR_SIZE SIZE_K(16) | |||
|
|||
#elif defined(PLATFORM_FLAVOR_rk3588) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a SoC as the name of the flavor is not a good idea IMO. How would you name different boards using the same SoC? Although yes, ideally if we use DT and runtime detection etc. it may be possible but it doesn't seem to apply here.
It seems like the |
#define UART5_BASE 0xfeb80000 | ||
#define UART5_SIZE SIZE_K(64) | ||
|
||
#define FIREWALL_DDR_BASE 0xfe030000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see rk3588 has two firewalls: FIREWALL_DDR
with base address 0xFE030000
and FIREWALL_SYSMEM
with base address 0xFE038000
have you been able to find out the difference? I guess the FIREWALL_DDR
hold MMU registers, and FIREWALL_SYSMEM
holds SMMU registers, but I cannot confirm this.
|
||
register_phys_mem_pgdir(MEM_AREA_IO_SEC, FIREWALL_DDR_BASE, FIREWALL_DDR_SIZE); | ||
|
||
int platform_secure_ddr_region(int rgn, paddr_t st, size_t sz) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How have you been able to find out how to set MMU configuration for this SoC? I cannot find any exact MMU register mappings in SoC's TRM.
support to rockchip rock5b which use rk3588