libckteec: serialize_ck.c: serialize AES-GCM mechanism parameters #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maroueneboubakri
force-pushed
the
dev-pkcs11
branch
from
3f90dec to
6fa15f2
Compare
etienne-lms
reviewed
Dec 4, 2023
maroueneboubakri
force-pushed
the
dev-pkcs11
branch
from
6fa15f2 to
d62c461
Compare
|
Comments addressed |
etienne-lms
reviewed
Dec 4, 2023
There was a problem hiding this comment.
Aside my pending comment, the change looks good to me.
Reviewed-by: Etienne Carriere <[email protected]>.
|
Comment addressed an tag applied. |
|
It seems you forgot to update your branch. |
maroueneboubakri
force-pushed
the
dev-pkcs11
branch
from
d62c461 to
adb8792
Compare
Thanks ! done ! |
This commits adds serialize_mecha_aes_gcm() function to serialize_ck.c to support AES-GCM mechanism (CKM_AES_GCM) in libckteec. Co-developed-by: Etienne Carriere <[email protected]> Signed-off-by: Etienne Carriere <[email protected]> Signed-off-by: Marouene Boubakri <[email protected]> Reviewed-by: Etienne Carriere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
serialize_mecha_aes_gcm()function toserialize_ck.cto support AES-GCM mechanism (CKM_AES_GCM) in libckteec.