Added Support for Docker Secrets #700
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Support for Docker Secrets
|
|
|
@agolybev Is there any reason for you to not merge pull requests resolving the issues about implementing a secure way to transmit sensitive information to the container? This change from @francescocapuano (and the others who have tried in the past) won't hurt anyone but will make a lot of users (including me) 😀 happy. Right now we a all dealing with security issues because the JWT will show up in a public readable docker-compose.yml and in certain environments can't be hidden through dot-env easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Support for Docker Secrets