Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefilter/v1 #12477

Closed
wants to merge 2 commits into from
Closed

Prefilter/v1 #12477

wants to merge 2 commits into from

Conversation

victorjulien
Copy link
Member

@victorjulien victorjulien marked this pull request as draft January 25, 2025 09:34
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (53abe1e) to head (0e9df7c).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12477      +/-   ##
==========================================
+ Coverage   80.55%   80.57%   +0.01%     
==========================================
  Files         925      925              
  Lines      259303   259314      +11     
==========================================
+ Hits       208886   208935      +49     
+ Misses      50417    50379      -38
Flag Coverage Δ
fuzzcorpus 56.14% <90.47%> (-0.01%) ⬇️
livemode 19.40% <33.33%> (+<0.01%) ⬆️
pcap 44.26% <47.61%> (+0.05%) ⬆️
suricata-verify 63.37% <100.00%> (+0.03%) ⬆️
unittests 58.45% <80.95%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien marked this pull request as ready for review January 25, 2025 15:18
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24357

@victorjulien victorjulien marked this pull request as draft January 25, 2025 18:08
@victorjulien victorjulien force-pushed the prefilter/v1 branch 2 times, most recently from c14763d to 283c053 Compare January 25, 2025 20:51
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24360

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24361

@victorjulien
detect/prefilter: fix prefilter setup
ec35b1b 
If `prefilter` is used it should override automatic fast pattern
selection.

Fixes: d6b5692 ("detect: set mpm/prefilter during signature parsing")

Ticket: OISF#7523.
@victorjulien
detect: remove unused SignatureInitData member
0e9df7c
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24373

@victorjulien victorjulien mentioned this pull request Jan 28, 2025
Closed
@victorjulien
Copy link
Member Author

replaced by #12489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorjulien @suricata-qa