Minor optimizations/v1 #12398
Open
Minor optimizations/v1 #12398
+51
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now the implementation would scan the stream, fallback to the packet payload, then keep track of where the match was and in the flow match logic reject the match if it was in the wrong buffer. This patch simplifies this logic, by refusing to inspect the packet payload when `only_stream` is set.
To assist branch prediction, which showed a 100% miss rate, assume pstate is non-NULL. Code review suggests all paths leading to the function actually check pstate first, or alstate which can only be non-NULL if pstate was first initialized. For now add a debug check.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12398 +/- ##
==========================================
- Coverage 80.63% 80.63% -0.01%
==========================================
Files 917 917
Lines 258687 258696 +9
==========================================
+ Hits 208601 208608 +7
- Misses 50086 50088 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
inashivb
reviewed
Jan 15, 2025
| // Failed to allocate larger memory for all the SIDS, but | ||
| // keep as many as we can. | ||
| sids_size = pmq->rule_id_array_size - pmq->rule_id_array_cnt; | ||
| if (sids_size > 0) { |
There was a problem hiding this comment.
Not following why is an extra indentation preferable over return if base condition doesn't match.
There was a problem hiding this comment.
The logic I think is that it assumes the first branch (so sids_size == 0 leading to return) to be the most likely.
|
Information: QA ran without warnings. Pipeline 24219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misc optimizations from running vtune.