Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple stream bypass from TLS encrypted bypass v8.1 #12388

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Decouple stream bypass from TLS encrypted bypass v8.1 #12388

wants to merge 4 commits into from
+121 −37

Conversation

lukashino
Copy link
Contributor

Following up on #12387

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6788

Describe changes:
v8.1:

  • specify the correct SV test

v8:

v7

  • Style guide changes as suggested in the prev PR
  • Encryption Handling has now three states, similar to TLS
  • rebased

v6

  • rebased

v5

  • rebased
  • added upgrade section
  • fixed docs - Thanks Juliana
  • SV tests should pass now

v4

  • rebased
  • changed SSH bypass defaults to hopefully be in sync with the previous settings

v3

  • added SSH app-layer option encryption-handling allowing to choose whether to continue inspection on SSH once it turns encrypted
  • added SV tests
  • minor docs updates

SV_BRANCH=OISF/suricata-verify#2233

Lukas Sismis and others added 4 commits January 13, 2025 13:09
@lukashino
ssh: add option to select behavior of encrypted parts
b8897ce 
Ticket: 6788
@msdean @lukashino
stream: decouple stream.bypass dependency from tls bypass
65504b3 
Decouple app.protocols.tls.encryption-handling and stream.bypass.
There's no apparent reason why encrypted TLS bypass traffic should
depend on stream bypass, as these are unrelated features.

Ticket: 6788
@lukashino
doc: remove trailing spaces in DPDK section
0aa01dd
@lukashino
ssh: sync the hassh setting with the defaults
541bd34
@lukashino lukashino mentioned this pull request Jan 13, 2025
Closed
@github-actions GitHub Actions
Copy link

NOTE: This PR may contain new authors.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.flow.end.state.local_bypassed 26015 17671 67.93%
IPS_AFP_stats_chk
.flow.end.state.local_bypassed 1080 0 -
.flow_bypassed.local_pkts 25920 0 -
.flow_bypassed.local_bytes 2833920 0 -

Pipeline 24192

@victorjulien victorjulien self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber Awaiting requested review from catenacyber catenacyber is a code owner

@jufajardini jufajardini Awaiting requested review from jufajardini jufajardini is a code owner

@victorjulien victorjulien Awaiting requested review from victorjulien victorjulien is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@victorjulien victorjulien

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukashino @suricata-qa @victorjulien @msdean