-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect: add vlan keyword - v11 #12386
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved previous PR and the diff looks good to fix the nit by Victor
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12386 +/- ##
==========================================
+ Coverage 82.46% 82.49% +0.02%
==========================================
Files 914 916 +2
Lines 258316 258563 +247
==========================================
+ Hits 213030 213295 +265
+ Misses 45286 45268 -18
Flags with carried forward coverage won't be shown. Click here to find out more. |
WARNING:
Pipeline 24188 |
Haven't looked at why, but in my FreeBSD 13 builder, this fails to build:
|
Ticket: #1065
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/1065
Description:
Changes:
rs_detect_vlan_id_free
andrs_detect_vlan_id_parse
toSCDetectVlanIdFree
andSCDetectVlanIdParse
SV_BRANCH=OISF/suricata-verify#2222
Previous PR: #12374