ftp: Begin conversion process to rust. #12376
Open
+371
−226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: 4082 As part of the effort to convert the FTP/FTPDATA parser to Rust, move the enums from C to Rust.
This commit moves the allocation logic from C to Rust for the FTP parser. Issue: 4082
Issue: 4082 Move the FTP enumeration values to a new module -- constant.rs -- for refactoring.
Issue: 4082 Move the FtpCommand structure to Rust.
Issue: 4082 Move config value handling to Rust. Use get_memval for the memcap and line-len values (since line-len is often expressed with a kb suffix)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12376 +/- ##
==========================================
- Coverage 82.49% 82.48% -0.01%
==========================================
Files 912 913 +1
Lines 258220 258273 +53
==========================================
+ Hits 213006 213039 +33
- Misses 45214 45234 +20
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24168 |
|
Looks pretty clean, and a nice start. |
Issue: 4082 Convert the FTP command table to rust. The command table is loaded into MPM to efficiently return the observed command. Formerly in C, the conversion to Rust incorporates the FTP command info into the FTP TX instead of incorporating it as a reference.
Issue: 4082 Rename the existing rs_* parsing functions (pasv, port, epsv, eprt) to follow the new API nomenclature.
|
Information: QA ran without warnings. Pipeline 24171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ftp: Partial conversion of the FTP protocol parser to Rust.
This PR represents partial completion of issue 4082.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/4082
Describe changes:
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCHvariable.SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=