util/debug: exit is not thread safe

The exit() function is not thread safe and triggers a warning from clang tidy for all FatalError() and FatalErrorAtInit() calls. This patch uses quick_exit instead to only flush the critical IO and not call the static destructors (which are the non thread safe part).
OISF · Dec 27, 2024 · 0132180 · 0132180
1 parent e8ab4d3
commit 0132180
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/configure.ac b/configure.ac
@@ -224,6 +224,11 @@
         [], [
             #include <x86intrin.h> 
             ])
+    AC_CHECK_DECL([quick_exit],
+        AC_DEFINE([HAVE_QUICK_EXIT], [1], [Use quick_exit]),
+        [], [
+            #include <stdlib.h>
+            ])
 
     AC_CHECK_HEADERS([malloc.h])
     AC_CHECK_DECL([malloc_trim],

diff --git a/src/util-debug.h b/src/util-debug.h
@@ -499,10 +499,14 @@ void SCLogErr(int x, const char *file, const char *func, const int line, const c
 
 #endif /* DEBUG */
 
+#if !HAVE_QUICK_EXIT
+#define quick_exit exit
+#endif
+
 #define FatalError(...)                                                                            \
     do {                                                                                           \
         SCLogError(__VA_ARGS__);                                                                   \
-        exit(EXIT_FAILURE);                                                                        \
+        quick_exit(EXIT_FAILURE);                                                                  \
     } while (0)
 
 /** \brief Fatal error IF we're starting up, and configured to consider
@@ -515,7 +519,7 @@ void SCLogErr(int x, const char *file, const char *func, const int line, const c
         (void)ConfGetBool("engine.init-failure-fatal", &init_errors_fatal);                        \
         if (init_errors_fatal && (SC_ATOMIC_GET(engine_stage) == SURICATA_INIT)) {                 \
             SCLogError(__VA_ARGS__);                                                               \
-            exit(EXIT_FAILURE);                                                                    \
+            quick_exit(EXIT_FAILURE);                                                              \
         }                                                                                          \
         SCLogWarning(__VA_ARGS__);                                                                 \
     } while (0)