Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firewall/v1 #2058

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Firewall/v1 #2058

wants to merge 3 commits into from

Conversation

victorjulien
Copy link
Member

@catenacyber
Copy link
Collaborator

This is a draft, right ?

@victorjulien
Copy link
Member Author

This is a draft, right ?

Why?

@catenacyber
Copy link
Collaborator

The wording Some initial tests towards made me think so.
Are the tests supposed to pass ?

@jasonish
Copy link
Member

If possible, it might be nice to see what "user" story each scenario is testing?

@victorjulien
Copy link
Member Author

Not sure I get it. Each test has a README that describes the test. What else is needed?

@jasonish
Copy link
Member

jasonish commented Sep 25, 2024

Not sure I get it. Each test has a README that describes the test. What else is needed?

Was thinking of something more applicable to an end-user looking for examples.. Like:

Where stuff like 3whs is a lower level implementation detail. Or perhaps that is better suited for the firewall chapter in the docs?

@victorjulien
Copy link
Member Author

This is not for users, but are tests for supporting development. The tests are self documenting in my opinion.

@jufajardini
Copy link
Contributor

Not sure I get it. Each test has a README that describes the test. What else is needed?

Was thinking of something more applicable to an end-user looking for examples.. Like:

* drop all TLS except with sni [www.google.com](http://www.google.com)

* drop all else

Where stuff like 3whs is a lower level implementation detail. Or perhaps that is better suited for the firewall chapter in the docs?

I guess we can add explanations in docs and link to the tests, and then one would complement the other 🤔

@catenacyber catenacyber added the tests pass These new tests should pass label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests pass These new tests should pass
Development

Successfully merging this pull request may close these issues.

4 participants