-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firewall/v1 #2058
base: master
Are you sure you want to change the base?
Firewall/v1 #2058
Conversation
Tests that flow is TLS and if SNI is expected.
bb2000c
to
ce48af6
Compare
This is a draft, right ? |
Why? |
The wording |
If possible, it might be nice to see what "user" story each scenario is testing? |
Not sure I get it. Each test has a README that describes the test. What else is needed? |
Was thinking of something more applicable to an end-user looking for examples.. Like:
Where stuff like 3whs is a lower level implementation detail. Or perhaps that is better suited for the firewall chapter in the docs? |
This is not for users, but are tests for supporting development. The tests are self documenting in my opinion. |
I guess we can add explanations in docs and link to the tests, and then one would complement the other 🤔 |
Some initial tests towards https://redmine.openinfosecfoundation.org/issues/7269