tegraXXX-helper-scripts: add TNSPEC length check

Generate an error during BUP generation if the TNSPEC will be longer than 63 characters, since the tools that deal with BUPs have a hard limit on that length. Signed-off-by: Matt Madison <[email protected]>
OE4T · Mar 23, 2021 · 40701c9 · 40701c9
1 parent b297055
commit 40701c9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/recipes-bsp/tegra-binaries/tegra-helper-scripts/tegra186-flash-helper.sh b/recipes-bsp/tegra-binaries/tegra-helper-scripts/tegra186-flash-helper.sh
@@ -318,6 +318,10 @@ if [ $bup_blob -ne 0 ]; then
     localbootfile="boot.img"
     . "$here/l4t_bup_gen.func"
     spec="${BOARDID}-${FAB}-${BOARDSKU}--1-0-${MACHINE}-${BOOTDEV}"
+    if [ $(expr length "$spec") -ge 64 ]; then
+	echo "ERR: TNSPEC must be shorter than 64 characters: $spec" >&2
+	exit 1
+    fi
     l4t_bup_gen "$flashcmd" "$spec" "$fuselevel" t186ref "$keyfile" "$sbk_keyfile" 0x18 || exit 1
 else
     eval $flashcmd || exit 1

diff --git a/recipes-bsp/tegra-binaries/tegra-helper-scripts/tegra194-flash-helper.sh b/recipes-bsp/tegra-binaries/tegra-helper-scripts/tegra194-flash-helper.sh
@@ -432,6 +432,10 @@ if [ $bup_blob -ne 0 ]; then
     localbootfile="boot.img"
     . "$here/l4t_bup_gen.func"
     spec="${BOARDID}-${FAB}-${BOARDSKU}-${BOARDREV}-1-${CHIPREV}-${MACHINE}-${BOOTDEV}"
+    if [ $(expr length "$spec") -ge 64 ]; then
+	echo "ERR: TNSPEC must be shorter than 64 characters: $spec" >&2
+	exit 1
+    fi
     l4t_bup_gen "$flashcmd" "$spec" "$fuselevel" t186ref "$keyfile" "$sbk_keyfile" 0x19 || exit 1
 else
     eval $flashcmd < /dev/null || exit 1

diff --git a/recipes-bsp/tegra-binaries/tegra-helper-scripts/tegra210-flash-helper.sh b/recipes-bsp/tegra-binaries/tegra-helper-scripts/tegra210-flash-helper.sh
@@ -287,6 +287,10 @@ if [ $bup_blob -ne 0 ]; then
     localbootfile="boot.img"
     . "$here/l4t_bup_gen.func"
     spec="${BOARDID}-${FAB}-${BOARDSKU}-${BOARDREV}-1-0-${MACHINE}-${BOOTDEV}"
+    if [ $(expr length "$spec") -ge 64 ]; then
+	echo "ERR: TNSPEC must be shorter than 64 characters: $spec" >&2
+	exit 1
+    fi
     l4t_bup_gen "$flashcmd" "$spec" "$fuselevel" t210ref "$keyfile" "" 0x21 || exit 1
 else
     if [ -z "$keyfile" ]; then