Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for pull requests (GitHub action) #892

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stweil
Copy link
Contributor

@stweil stweil commented Jul 16, 2022

Signed-off-by: Stefan Weil [email protected]

@stweil
Copy link
Contributor Author

stweil commented Jul 16, 2022

See this example of a bad pull request which triggers a CI failure.

@stweil
Copy link
Contributor Author

stweil commented Apr 15, 2024

@kba, please merge.

@stweil
Copy link
Contributor Author

stweil commented Apr 15, 2024

This new GitHub action currently checks pull requests for whitespace issues. It can be extended to

  • check for typos
  • check for author names without valid name and e-mail
  • check for valid signature
  • more?

What formal checks for pull requests should be added?

The action code includes code from https://github.com/JensDll/should-run. That is a GitHub action which could be used to select the CI tests depending on the changes made by a pull request. For example the pull request here does not change code, so running all CI tests is not necessary and currently wasting resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant