client_utils: use a retrying http client #1281
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MehmedGIT
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
I do not see any downsides of a retrying HTTP client that would keep us away from it.
The only small disadvantage may be filled logs on the Processing Server side when 500 errors occur, since the server returns these for unexpected errors. The other error codes are reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added those to my local fork for robustness to handle network connectivity issues. Not sure how sensible that is and hard to investigate how effective this is, so just a draft for now. If we decide it does make sense to have a retrying (and possibly also debouncing retries for more failure resilience) http client, we could generalize this.
(copied from 3b040b7 by @bertsky)