-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone Processor Server (#884 + #974) #1030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good already.
Not yet. There is still duplication of code. Mainly in the deployment phase.
The reason I said that was to keep #1030 small because most of the things you mentioned in your review would have probably changed in the coming commits. For me going through your review for the current time being and answering everything separately in detail is more time-consuming than actually fixing things. Especially, when things are still not optimized and duplication of code is still out there (due to a clash of implementation ideas of 3 different people which I am trying to combine in #1030). Also, the logging in |
ocrd_validators/ocrd_validators/processing_server_config.schema.yml
Outdated
Show resolved
Hide resolved
@kba, the blocking API for the Processor Servers and non-blocking requests to the Processor Servers from Processing Server have been implemented. This PR should now be good to be merged. |
AFAICT the only open discussion is the one around timeouts - shall I move this to a separate issue? Otherwise, I'll merge after our call later, many thanks! |
Now or never! |
This draft PR is supposed to get important aspects from #884 and adapt to #974 so it can extend the
ocrd_network
package to provide the standalone Processor Server feature.I am creating this a bit early so it's easy to follow what is going on with this.
Still broken and fixes are needed.A lot more refactoring is needed to follow afterward. EDIT: Refactored and on the surface seems to work now.Feel free to provide feedback.