[16.0][FIX] fs_attachment: fix fs_url computing

[kobros-tech]

• Assuming that the optimized directory is checked and the directory path is not checked:

  • If the image is checked as obfuscated:

    • then the fs_url refers to the image in its/dir1/dir2 directories that are named from checksum first 4 digits and this is fine.

  • But, if the image is not obfuscated:

    • then the "_get_url_for_attachment" method still computes the default method, forgetting that the fs_filename is the readable name and not obfuscated.

    I had to add the /dir1/dir2 to generate the correct URL

The module still needs testing and debugging, many tests failed and I see that store_fname is neglecting the directory path although it can be added like in my case.

I am looking forward to continuing debugging with assistance from the contributors.

Thanks All...

[kobros-tech]

@OCA-git-bot

@sebastienbeau

@lmignon

@mymage

[lmignon]

What's the protocol of your storage? Protocol is a required field and there is nor more default value on it on the 16.0 branch. Be careful to don't serve your images from the odoo's filestore in a public way. If you configure your proxy to get access to the filestore under the 'images' path, you expose all the files from your odoo instance....

[kobros-tech]

@lmignon

Thanks for clarifying, but I use different filestore for only products imsges thumbnails.

But the bug is completely different from these settings that you mentioned.

I can use many protocols and to test I used file protocol.

Thanks

[lmignon]

Thank you for the fix @kobros-tech LGTM (Code review only)