-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] fs_attachment: fix fs_url computing #404
base: 16.0
Are you sure you want to change the base?
Conversation
3efe0b5
to
bb8164f
Compare
) | ||
|
||
# Create a mock image filestore | ||
fs_storage = self.env["fs.storage"].create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the protocol of your storage? Protocol is a required field and there is nor more default value on it on the 16.0 branch. Be careful to don't serve your images from the odoo's filestore in a public way. If you configure your proxy to get access to the filestore under the 'images' path, you expose all the files from your odoo instance....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying, but I use different filestore for only products imsges thumbnails.
But the bug is completely different from these settings that you mentioned.
I can use many protocols and to test I used file protocol.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix @kobros-tech LGTM (Code review only)
If the image is checked as obfuscated:
But, if the image is not obfuscated:
I had to add the /dir1/dir2 to generate the correct URL
The module still needs testing and debugging, many tests failed and I see that store_fname is neglecting the directory path although it can be added like in my case.
I am looking forward to continuing debugging with assistance from the contributors.
Thanks All...