Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] fs_product_multi_image: ensure to have a string when sorting variant images #389

Merged

Conversation

benwillig
Copy link
Contributor

When adding multiple images on a product using the kanban view, an error was raised when saving the product. When the compute runs for the first time, names are False so it crashes.

@OCA-git-bot
Copy link
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@benwillig benwillig changed the title [FIX] fs_product_multi_image: ensure to have a string when sorting variant images [16.0][FIX] fs_product_multi_image: ensure to have a string when sorting variant images Sep 22, 2024
@lmignon
Copy link
Contributor

lmignon commented Sep 24, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-389-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3e87aea into OCA:16.0 Sep 24, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eeeea37. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-fs_product_multi_image_fix_sorted-bwi branch September 24, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants