[16.0][IMP] stock_inventory_discrepancy: better inheritance #2232
+41
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@HviorForgeFlow Any reason not to revert back to this more common way? |
rvalyi
previously requested changes
Jan 10, 2025
thomaspaulb
force-pushed
the
16.0-stock_inventory_discrepancy-better_inheritance
branch
from
a6f5c1d to
bfd7067
Compare
No, I guess it was a decision without taking a count a possible inheritance. It makes more sense move it away from a hook. |
thomaspaulb
force-pushed
the
16.0-stock_inventory_discrepancy-better_inheritance
branch
from
bfd7067 to
3a0c20a
Compare
During the migration to 13.0 of this module it was decided to introduce a hook. Refactoring to a regular override plays better with inheritance.
thomaspaulb
force-pushed
the
16.0-stock_inventory_discrepancy-better_inheritance
branch
from
3a0c20a to
dcfd0dc
Compare
|
Now green |
HviorForgeFlow
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the migration to 13.0 of this module it was decided to introduce a hook.
Refactoring to a regular override plays better with inheritance.