[FIX] mail_send_copy: work with existing BCC+adding tests #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liklee-it
force-pushed
the
15.0-fix-mail_send_copy
branch
from
6bf8426 to
2b41d52
Compare
hbrunn
requested changes
Dec 27, 2024
mail_send_copy/__manifest__.py
Outdated
| @@ -4,7 +4,7 @@ | |||
| { | |||
| "name": "Mail - Send Email Copy", | |||
| "summary": "Send to you a copy of each mail sent by Odoo", | |||
| "version": "15.0.1.0.0", | |||
| "version": "15.0.1.0.1", | |||
There was a problem hiding this comment.
please don't increase the version manually, we do this during merge
| # Set the combined Bcc | ||
| message.replace_header( | ||
| "Bcc", all_bcc | ||
| ) if "Bcc" in message else message.add_header("Bcc", all_bcc) |
There was a problem hiding this comment.
why don't you use a normal conditional here?
There was a problem hiding this comment.
just free style :) and sure, I will update it
liklee-it
force-pushed
the
15.0-fix-mail_send_copy
branch
from
69e2a69 to
6f9b684
Compare
hbrunn
approved these changes
Dec 28, 2024
|
cc @Kev-Roche @metaminux @nilshamerlinck to review, thx! |
trisdoan
reviewed
Jan 9, 2025
Comment on lines
+4
to
+5
| # TODO: find a way to test sending email with existing BCC | ||
|
|
There was a problem hiding this comment.
Hi, could you consider this test please?
@tagged("post_install", "-at_install")
class TestMailSendWithBcc(TestMailSendCopy):
def test_send_email_with_existing_bcc(self):
if not self.env["ir.module.module"].search(
[("name", "=", "mail_composer_cc_bcc"), ("state", "=", "installed")]
):
self.skipTest("mail_composer_cc_bcc module is required for this test")
partner_bcc = self.env.ref("base.res_partner_main2")
composer = self.env["mail.compose.message"].create(
{
"partner_ids": [(6, 0, [self.partner.id])],
"subject": "Test Subject",
"body": "<p>Test Body</p>",
"email_from": "[email protected]",
}
)
composer.partner_bcc_ids = partner_bcc
with patch(
"odoo.addons.base.models.ir_mail_server.IrMailServer.send_email"
) as mock_send_email:
composer._action_send_mail()
# Verify that send_email was called
self.assertTrue(mock_send_email.called)
call_args = mock_send_email.call_args[0]
message = call_args[0]
# Check existing BCC in the email message
self.assertIn("[email protected]", message["Bcc"])
There was a problem hiding this comment.
Nice idea, thanks. I have added them in the commit. It seems working, but here I cannot find the results of codecov anymore :( Have I done something wrong?
|
FYI, If you're interested in |
liklee-it
force-pushed
the
15.0-fix-mail_send_copy
branch
from
6f9b684 to
018a625
Compare
[FIX] mail_send_copy: work with existing BCC+adding tests2 [IMP] improve code for OCA convention [IMP] mail_send_copy: add test for sending email with bcc
liklee-it
force-pushed
the
15.0-fix-mail_send_copy
branch
from
018a625 to
7d3a8f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mail_send_copy doesn't work with the module mail_composer_cc_bcc because there is a mistake in the line
if message["Bcc"]:message["Bcc"] = message["Bcc"].join(COMMASPACE, message["From"])This PR fixes this issue.
This PR adds tests as well