Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP]mail_quoted_reply: Separate reply body #1516

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

ChristophAbenthungCibex
Copy link
Contributor

For long replies the message composer gets extremely laggy and slow. This applies to text written in the composer (body) and for opening the composer.

Steps to reproduce:

  1. Go to any chatter
  2. Send a message
  3. Reply to that message
  4. Keep replying to the newly sent message

After a couple of message the composer will open slowly (couple seconds till it opens) and respond slowly to an input.

This pull request separates the reply body into another field. This field is read-only after opening the composer. It can be changed to be writable. However, depending on how long the reply is the time needed to activate it differs.
This feature can be en-/disabled with the system parameter "mail_quoted_reply.separate_reply_body".

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks fine, but please describe the feature in the readme.

This is of course only fixing a symptom, the underlying issue here is that the html widget doesn't deal well with big/complex content.

@ChristophAbenthungCibex
Copy link
Contributor Author

code looks fine, but please describe the feature in the readme.

This is of course only fixing a symptom, the underlying issue here is that the html widget doesn't deal well with big/complex content.

I updated the readme.

Yea it is only fixing a symptom. But as long as the html widget is that slow we need some sort of workaround/fix. Some replies loaded for over a minute before the composer opened and then the typed input was very delayed.

For long replies the message composer gets extremely laggy and slow. To prevent that the reply body is stored in a separate field.
@ChristophAbenthungCibex
Copy link
Contributor Author

Had to change the compute for "is_separate_body" because the feature was enabled for new messages too. Not just for replies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants