18.0 mig base tier validation #964

…on and validate if possible.

…ation records

* able to restart validation * sudo() not needed anymore

and reject can be hidden according to this computed field.

… and who asks for reviews in new fields 'done_by' and 'requested_by'.

fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu

…reviews' name and state correctly translated.

* using similar approach to activities has already benn addressed. * add a new point explaining review tooltip improvement possibilities.

Currently translated at 100.0% (59 of 59 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation/zh_CN/

notification to possible reviewers.

* fix test after the last forward-ported feature. * add a descrition of new know issue.

… rebranding of Eficent to ForgeFlow.

…tified. A customer or supplier can be a follower of the object and should not receive internal messages about the tier validation.

…tion record

Currently translated at 100.0% (74 of 74 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation/zh_CN/

Currently translated at 80.0% (60 of 75 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation/es/

…definition

…urchase modules installed

…er modules installed

- When use approve by sequence, still approve tier of the same reviewer - When using approve_sequence option in any tier.definition there can be inconsistencies in the systray notifications

Currently translated at 96.1% (73 of 76 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation/zh_CN/

This commit splits the state condition checking part into another method, allowing inheriting modules to override the conditions as needed.

Currently translated at 87.3% (76 of 87 strings) Translation: server-ux-14.0/server-ux-14.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_tier_validation/es/

…ation has not yet started

…ications from requested tier validations TT29001

…saved data You can't search for a NewId in a domain, and doing a search requires to flush cache contents to DB for being effective, so this disregards the correct use of this on the fly computed field. Fortunately, we have a tool at ORM level for applying domains on cached content and without worrying about NewId, which is filtered_domain, so let's apply it.

…ges. - can_review_message - validated_message - rejected_message This introduces the possibility to customize the messages.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-15.0/server-ux-15.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-base_tier_validation/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/

Currently translated at 77.1% (81 of 105 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/it/

- Add _check_state_from_condition() method to better clarify the code and to be able to inherit it by another module. - Add _add_tier_validation_x() methods to better clarify the code and to be able to inherit it by another module. - Add name to th + td from ReviewsTable for a better selector if another module needs it. TT43351

Currently translated at 77.1% (81 of 105 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/it/

Currently translated at 100.0% (104 of 104 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/es/

…ted modules

A method for deciding whether or not to remove related reviews is added. TT43351

Currently translated at 100.0% (109 of 109 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/es/

[BOT] post-merge updates

Currently translated at 100.0% (109 of 109 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/fr/

…ation TT33369

…_tier_validation_model_names() Even if they are models that are only used in tests, it is necessary to add the tier.validation.tester and tier.validation.tester2 to the tier.definition's _get_tier_validation_model_names() method. TT33369

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/

…te fields Before this commit, in a database with many records candidates for applying reviews, fields with a defined search function were very slow because the search was performed over all records with these states. After this commit, first filter only records with review_ids set, which significantly reduces performance by more than 10X!!!

Currently translated at 72.9% (81 of 111 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/it/

…ame reviewer [BOT] post-merge updates

Currently translated at 72.9% (81 of 111 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/it/

…mpany In a multicompany environment as follows: User Request. Selected Companies: C1, C2, Current Company C1 User Approver: Selected Companies: C1 Current Company C1 Before this commit, when a user requested validation with multicompany enabled (C1, C2), definitions of other companies could be applied. If the user approver had access to fewer companies (C1) and confirmed the document, then the remaining reviews (C2) were ignored in the pending state. These reviews were shown on the sidebar but could never be approved because the document had already been approved. After this commit, tier definitions are filtered only by the current company of the user request. [BOT] post-merge updates

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/

Currently translated at 100.0% (114 of 114 strings) Translation: server-ux-16.0/server-ux-16.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_tier_validation/es/ [BOT] post-merge updates

- Include context keys for avoiding mail operations overhead. [BOT] post-merge updates

… allow inheritance TT45804 [BOT] post-merge updates

And some part of the field are not show.

[BOT] post-merge updates

Co-authored-by: Carlos Lopez <[email protected]>

…t translatable

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/

Currently translated at 100.0% (118 of 118 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/es/

Currently translated at 66.1% (78 of 118 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

Currently translated at 69.4% (82 of 118 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

Currently translated at 100.0% (118 of 118 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

Variables were inconsistently named leading to confusion when understanding the code. [BOT] post-merge updates [BOT] post-merge updates

Currently translated at 94.9% (112 of 118 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/nl_NL/

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/

Currently translated at 100.0% (119 of 119 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/

Currently translated at 100.0% (125 of 125 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

[BOT] post-merge updates

Currently translated at 100.0% (125 of 125 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/es/

Currently translated at 100.0% (125 of 125 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

Currently translated at 100.0% (125 of 125 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/sv/

Currently translated at 100.0% (125 of 125 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

- when option approve_sequence_bypass is enable and comments option with sequence, the user add a comment and all level approbation add this comment. This code add comment only for appropriate tier validation.

…licit access

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/

Currently translated at 100.0% (141 of 141 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

[BOT] post-merge updates

Silence the warning: Two fields (model_name, model_id) of tier.validation.exception() have the same label: Model. [Modules: base_tier_validation and base_tier_validation]

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/

[BOT] post-merge updates

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/

Currently translated at 100.0% (143 of 143 strings) Translation: server-ux-17.0/server-ux-17.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-base_tier_validation/it/

Previous implementation was losing fields in some cases; new one properly merges dicts/tuples. This fixes odd "Missing field string information" errors in form-embedded lists. This cset also removes an obsolete `base_model_name` context key no longer used in Odoo 16. This cset adds a `test_get_view` test which checks for that `need_validation` field; it was failing with the previous impl. Fixes OCA#825. [BOT] post-merge updates

[BOT] post-merge updates

Computed fields bypass `write`, so we need to override `_write` for that case. Also, the current value before the update needs to be fetched from the database because the new value is already set in the cache. [BOT] post-merge updates

I just realized that a new author was added to the module during an improvement that merged the functionality of base_tier_validation_waiting. This was overlook during my review and not explicitly accepted. There have been many contributors adding new functionalities and this one was not specially big to be included as author. [BOT] post-merge updates

[ADD][base_tier_validation] Adding test requirements [ADD][base_tier_validation] Adding test requirements [ADD][base_tier_validation] Adding test requirements [FIX][base_tier_validation] Fix on tests [FIX][base_tier_validation] Adding group on rule

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

18.0 mig base tier validation #964

18.0 mig base tier validation #964

Commits on Oct 29, 2024

Commits on Oct 30, 2024

18.0 mig base tier validation #964

Are you sure you want to change the base?

18.0 mig base tier validation #964

Commits on Oct 29, 2024

Commits on Oct 30, 2024