[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

trisdoan · 2024-10-10T02:37:20Z

No description provided.

…avoid incompatibilities with data from those users.

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/tr/

Currently translated at 18.6% (8 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sl/

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/es/

Currently translated at 58.1% (25 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/

Currently translated at 95.3% (41 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/fr/

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/de/

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sv/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/

Currently translated at 100.0% (44 of 44 strings) Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/es_MX/

Currently translated at 100.0% (44 of 44 strings) Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/it/

…y field

…TumbaoJu

…TumbaoJu

pedrobaeza · 2024-10-10T06:27:11Z

/ocabot migration server_action_mass_edit

florenciafrigieri2 · 2024-10-16T13:44:28Z

@trisdoan Hi! I tested the module but it didn't worked.
I created a server action to change the salesperson in the SOs, but when selecting the action within sales an error came up (I was not able to even see the wizard).

This are the last lines of the error:
File "/mnt/data/odoo-addons-dir/server_action_mass_edit/wizard/mass_editing_wizard.py", line 93, in onchange
dynamic_fields["selection__" + line.field_id.name] = fields.Selection(
File "/opt/odoo/odoo/fields.py", line 2772, in init
self._selection = dict(selection) if isinstance(selection, list) else None
ValueError: dictionary update sequence element #0 has length 0; 2 is required

I leave here a print of the server action

trisdoan · 2024-10-18T08:45:55Z

@trisdoan Hi! I tested the module but it didn't worked. I created a server action to change the salesperson in the SOs, but when selecting the action within sales an error came up (I was not able to even see the wizard).

This are the last lines of the error: File "/mnt/data/odoo-addons-dir/server_action_mass_edit/wizard/mass_editing_wizard.py", line 93, in onchange dynamic_fields["selection__" + line.field_id.name] = fields.Selection( File "/opt/odoo/odoo/fields.py", line 2772, in init self._selection = dict(selection) if isinstance(selection, list) else None ValueError: dictionary update sequence element #0 has length 0; 2 is required

I leave here a print of the server action

Hi @florenciafrigieri2, thank you for the review

I just added a fix, could you please try again?

TDu

I don't see the error mentioned by @florenciafrigieri2 anymore, but I am not familiar with this module !
Code review looks good.

henrybackman

Couple of minor comments

henrybackman · 2024-10-29T14:45:46Z

server_action_mass_edit/tests/test_mass_editing.py

+
+@common.tagged("-at_install", "post_install")
+class TestMassEditing(common.TransactionCase):
+    def setUp(self):


Would setUpClass work for the common test setup to avoid running the setup separately for each test case?

henrybackman · 2024-10-29T14:51:26Z

server_action_mass_edit/tests/test_mass_editing.py

+    def test_wiz_fields_view_get(self):
+        """Test whether fields_view_get method returns arch.


Suggested change

def test_wiz_fields_view_get(self):

"""Test whether fields_view_get method returns arch.

def test_wiz_get_view(self):

"""Test whether get_view method returns arch.

henrybackman · 2024-10-29T14:52:34Z

server_action_mass_edit/wizard/mass_editing_wizard.py

+        return vals_list
+
+    def read(self, fields=None, load="_classic_read"):
+        """Without this call, dynamic fields build by fields_view_get()


Suggested change

"""Without this call, dynamic fields build by fields_view_get()

"""Without this call, dynamic fields build by get_view()

florenciafrigieri2

Functional test! Now is working ok!

OCA-git-bot · 2024-10-29T15:07:27Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

stefsava · 2024-10-29T18:25:52Z

It seems like there is a regression.
I can't bulk insert product attributes, while I could do it in 17.0.

Before it asked me to add a line,
now it doesn't ask and there are multiple columns.

With 17.0

With 18.0 and this PR

legalsylvain

See @stefsava comment.

legalsylvain and others added 24 commits October 10, 2024 09:36

[REF] rename 'mass_editing' module into 'server_action_mass_edit'

0c01396

[UPD] french translation

4907412

[IMP] server_action_mass_edit: Do not re-use demo and admin users to …

ebf4359

…avoid incompatibilities with data from those users.

Translated using Weblate (Turkish)

be6e833

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/tr/

Translated using Weblate (Slovenian)

0443acd

Currently translated at 18.6% (8 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sl/

[ADD] server_action_mass_edit: add support for o2m fields

01d0ad6

Translated using Weblate (Spanish)

7da98fd

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/es/

Translated using Weblate (Italian)

5efe4c6

Currently translated at 58.1% (25 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/

Translated using Weblate (French)

0194894

Currently translated at 95.3% (41 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/fr/

Translated using Weblate (German)

340b8ea

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/de/

Translated using Weblate (Italian)

86a406e

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/

[FIX] server_action_mass_edit: 'Add' readded to many2many

478f48d

Translated using Weblate (Swedish)

60b607a

Currently translated at 100.0% (43 of 43 strings) Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sv/

[IMP] server_action_mass_edit: black, isort, prettier

cc235b7

[MIG] server_action_mass_edit: Migration to 17.0

952d8d0

[UPD] Update server_action_mass_edit.pot

6fe9029

[BOT] post-merge updates

3b77235

Update translation files

2d5a8c2

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/

Translated using Weblate (Spanish (Mexico))

3a4e5c6

Currently translated at 100.0% (44 of 44 strings) Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/es_MX/

Translated using Weblate (Italian)

638ceea

Currently translated at 100.0% (44 of 44 strings) Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/it/

[FIX] server_action_mess_edit: Application error when discard a x2man…

c2d9d22

…y field

[BOT] post-merge updates

a2b4531

[IMP] Improve documentation during OCA Days 2024 Workshop thanks to @…

eb4d912

…TumbaoJu

[BOT] post-merge updates

daf63a7

trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch from 29381ab to 0f93b99 Compare October 10, 2024 02:43

OCA-git-bot added this to the 18.0 milestone Oct 10, 2024

OCA-git-bot mentioned this pull request Oct 10, 2024

Migration to version 18.0 #948

Open

17 tasks

trisdoan mentioned this pull request Oct 10, 2024

[18.0][MIG] server_action_mass_edit: Migration to 18.0 camptocamp/server-ux#2

Closed

[MIG] server_action_mass_edit: Migration to 18.0

7399b98

trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch from 0f93b99 to 7399b98 Compare October 18, 2024 08:45

TDu approved these changes Oct 29, 2024

View reviewed changes

henrybackman approved these changes Oct 29, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 29, 2024

florenciafrigieri2 approved these changes Oct 29, 2024

View reviewed changes

OCA-git-bot added the ready to merge label Oct 29, 2024

legalsylvain requested changes Oct 30, 2024

View reviewed changes

OCA-git-bot removed approved ready to merge labels Oct 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

trisdoan commented Oct 10, 2024

pedrobaeza commented Oct 10, 2024

florenciafrigieri2 commented Oct 16, 2024

trisdoan commented Oct 18, 2024

TDu left a comment

henrybackman left a comment

henrybackman Oct 29, 2024

henrybackman Oct 29, 2024

henrybackman Oct 29, 2024

florenciafrigieri2 left a comment

OCA-git-bot commented Oct 29, 2024

stefsava commented Oct 29, 2024

legalsylvain left a comment

		def test_wiz_fields_view_get(self):
		"""Test whether fields_view_get method returns arch.

	"""Without this call, dynamic fields build by fields_view_get()
	"""Without this call, dynamic fields build by get_view()

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

Are you sure you want to change the base?

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

Conversation

trisdoan commented Oct 10, 2024

pedrobaeza commented Oct 10, 2024

florenciafrigieri2 commented Oct 16, 2024

trisdoan commented Oct 18, 2024

TDu left a comment

Choose a reason for hiding this comment

henrybackman left a comment

Choose a reason for hiding this comment

henrybackman Oct 29, 2024

Choose a reason for hiding this comment

henrybackman Oct 29, 2024

Choose a reason for hiding this comment

henrybackman Oct 29, 2024

Choose a reason for hiding this comment

florenciafrigieri2 left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Oct 29, 2024

stefsava commented Oct 29, 2024

legalsylvain left a comment

Choose a reason for hiding this comment