Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] server_action_mass_edit: Migration to 18.0 #951

Open
wants to merge 25 commits into
base: 18.0
Choose a base branch
from

Conversation

trisdoan
Copy link

No description provided.

legalsylvain and others added 24 commits October 10, 2024 09:36
…avoid incompatibilities with data from those users.
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/tr/
Currently translated at 18.6% (8 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sl/
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/es/
Currently translated at 58.1% (25 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/
Currently translated at 95.3% (41 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/fr/
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/de/
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/it/
Currently translated at 100.0% (43 of 43 strings)

Translation: server-ux-16.0/server-ux-16.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-server_action_mass_edit/sv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/
Currently translated at 100.0% (44 of 44 strings)

Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/es_MX/
Currently translated at 100.0% (44 of 44 strings)

Translation: server-ux-17.0/server-ux-17.0-server_action_mass_edit
Translate-URL: https://translation.odoo-community.org/projects/server-ux-17-0/server-ux-17-0-server_action_mass_edit/it/
@trisdoan trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch from 29381ab to 0f93b99 Compare October 10, 2024 02:43
@pedrobaeza
Copy link
Member

/ocabot migration server_action_mass_edit

@florenciafrigieri2
Copy link

@trisdoan Hi! I tested the module but it didn't worked.
I created a server action to change the salesperson in the SOs, but when selecting the action within sales an error came up (I was not able to even see the wizard).

This are the last lines of the error:
File "/mnt/data/odoo-addons-dir/server_action_mass_edit/wizard/mass_editing_wizard.py", line 93, in onchange
dynamic_fields["selection__" + line.field_id.name] = fields.Selection(
File "/opt/odoo/odoo/fields.py", line 2772, in init
self._selection = dict(selection) if isinstance(selection, list) else None
ValueError: dictionary update sequence element #0 has length 0; 2 is required

I leave here a print of the server action
testserveraction

@trisdoan trisdoan force-pushed the 18.0-mig-server_action_mass_edit branch from 0f93b99 to 7399b98 Compare October 18, 2024 08:45
@trisdoan
Copy link
Author

@trisdoan Hi! I tested the module but it didn't worked. I created a server action to change the salesperson in the SOs, but when selecting the action within sales an error came up (I was not able to even see the wizard).

This are the last lines of the error: File "/mnt/data/odoo-addons-dir/server_action_mass_edit/wizard/mass_editing_wizard.py", line 93, in onchange dynamic_fields["selection__" + line.field_id.name] = fields.Selection( File "/opt/odoo/odoo/fields.py", line 2772, in init self._selection = dict(selection) if isinstance(selection, list) else None ValueError: dictionary update sequence element #0 has length 0; 2 is required

I leave here a print of the server action testserveraction

Hi @florenciafrigieri2, thank you for the review

I just added a fix, could you please try again?

Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the error mentioned by @florenciafrigieri2 anymore, but I am not familiar with this module !
Code review looks good.

Copy link

@henrybackman henrybackman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments


@common.tagged("-at_install", "post_install")
class TestMassEditing(common.TransactionCase):
def setUp(self):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would setUpClass work for the common test setup to avoid running the setup separately for each test case?

Comment on lines +132 to +133
def test_wiz_fields_view_get(self):
"""Test whether fields_view_get method returns arch.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_wiz_fields_view_get(self):
"""Test whether fields_view_get method returns arch.
def test_wiz_get_view(self):
"""Test whether get_view method returns arch.

return vals_list

def read(self, fields=None, load="_classic_read"):
"""Without this call, dynamic fields build by fields_view_get()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Without this call, dynamic fields build by fields_view_get()
"""Without this call, dynamic fields build by get_view()

Copy link

@florenciafrigieri2 florenciafrigieri2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test! Now is working ok!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@stefsava
Copy link

It seems like there is a regression.
I can't bulk insert product attributes, while I could do it in 17.0.

Before it asked me to add a line,
now it doesn't ask and there are multiple columns.

With 17.0
image
image

With 18.0 and this PR
image
image

Copy link
Contributor

@legalsylvain legalsylvain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See @stefsava comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.