[17.0][MIG] base_export_manager: Migration to 17.0 #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-s73
changed the title
|
Hello, this PR has been stuck for a while. Is there anything I can do to help unblock it? From what I see, the test coverage doesn't meet the expected threshold. Is it really necessary? |
|
Coverage isn't blocking. It simply has no reviewers |
|
I’m sorry to hear that there aren’t any reviewers assigned. If I can help, I’d be happy to assist! |
|
There's no need to assign reviewers, anyone can do it any time. You can ask the contributor for a re-push that triggers the runboat again to be able to test the funcionallity and you can do a full review in the context of the new version. |
|
@david-s73 Could you please do a re-push to trigger the runboat again? That way I can test the functionality and perform a full review on the latest version. Thanks! |
david-s73
force-pushed
the
17.0-mig-base_export_manager
branch
from
d1344d2
to
7568f0d
Compare
|
@benjilluch Done |
* Improve UX for base_export_manager. - Improve user instructions in README. - Require some required fields. - Allow to select models from a list. - Allow to select up to 3 fields from dynamic lists. - Improve translations. - More tests. - Translate column labels. Some methods have been renamed, so version tag is raised to 8.0.2.0.0. * Make inverse method be called at view time. * Hardcode constraints in the `create` method instead of using normal ones. Depending on the context where the record is created, it gets `resource` or `model_id`. The problem is that Odoo checks constrains before inverses, so constrains would fail always. Test added to ensure future versions contemplate all use cases. * Allow to reorder fields.
* Upgrade base_export_manager to v9 * Rename JS to base_export_manager
* Change osv_memory to transient for model_id domain
* Improve UX for base_export_manager. - Improve user instructions in README. - Require some required fields. - Allow to select models from a list. - Allow to select up to 3 fields from dynamic lists. - Improve translations. - More tests. - Translate column labels. Some methods have been renamed, so version tag is raised to 8.0.2.0.0. * Hardcode constraints in the `create` method instead of using normal ones. Depending on the context where the record is created, it gets `resource` or `model_id`. The problem is that Odoo checks constrains before inverses, so constrains would fail always. Test added to ensure future versions contemplate all use cases. * Allow to reorder fields.
…9 * Rename JS to base_export_manager
[FIX][base_export_manager] Fix "Expected singleton" bug.
If you had a field that got translated in more than 1 addon, you'd possibly getto this error:
File "/opt/odoo/0079_ahk_openerp/oca/base_export_manager/models/ir_exports_line.py", line 105, in _compute_label
field.name)),
File "/opt/odoo/common/openerp/v8/openerp/fields.py", line 825, in __get__
record.ensure_one()
File "/opt/odoo/common/openerp/v8/openerp/models.py", line 5355, in ensure_one
raise except_orm("ValueError", "Expected singleton: %s" % self)
except_orm: ('ValueError', 'Expected singleton: ir.translation(4899, 703976)')
With this patch, now we let Odoo return the translated string by using its
standard method to do so, so we have to care for less.
* Move installation outside a data file.
This makes the whole installation to be able to roll back if something goes
wrong, instead of entering an error loop.
* Include envorionment in its manager.
* Add 4th field
* Move to api.multi, refactoring some stuff.
- Add some comments in complex parts.
- Rename `onchange_name` to `_onchange_name` (guidelines).
- Make `_compute_name`'s try block shorter and easier to understand.
* Allow R/W of name directly in model.
* Update tests to cover new behaviors.
- Remove all possible translation commits - Aesthetical changes - Bump version - Some new standards, such as split readme Basically, nothing.
Currently translated at 80.0% (20 of 25 strings) Translation: server-ux-11.0/server-ux-11.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-11-0/server-ux-11-0-base_export_manager/da/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-12.0/server-ux-12.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_export_manager/pt/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-12.0/server-ux-12.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_export_manager/zh_CN/
Currently translated at 90.3% (28 of 31 strings) Translation: server-ux-12.0/server-ux-12.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_export_manager/hr/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-14.0/server-ux-14.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_export_manager/es/
If not, we are not assigning the label value for the record and we get a missing cache value error.
WARNING odoo.fields: Redundant default on ir.exports.line.model1_id
Steps to reproduce: - Create an export profile in any model. - Login with a user without setting permissions. - Go to export popup on that model. - Try to select the saved export profile. You'll get an access error. Using sudo for computed/related stuff linked to ir.model, we avoid the problem. TT44721
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-16.0/server-ux-16.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_export_manager/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-16.0/server-ux-16.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_export_manager/es/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-16.0/server-ux-16.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_export_manager/it/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-16.0/server-ux-16.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_export_manager/sv/
Currently translated at 100.0% (31 of 31 strings) Translation: server-ux-16.0/server-ux-16.0-base_export_manager Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_export_manager/pt_BR/
david-s73
force-pushed
the
17.0-mig-base_export_manager
branch
from
7568f0d
to
6faa883
Compare
|
I’ve just tested it on Runboat, and it works well. |
|
@chienandalu Could I ask if anything else is needed on this? |
|
@pedrobaeza Can you look into speeding up this issue? |
|
/ocabot migration base_export_manager |
|
You need to enroll reviewers https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#review One way is that you review other PRs, and ask in exchange that they review yours. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.