[FWP] [17.0] OCA-PORT PRs 802 860 888 902 921

[Shide]

PORTED:

• [16.0][PORT] 699 from 14.0: base_tier_validation multiple comment with approve_sequence_bypass #802
• [16.0][ADD] base_tier_validation: set all form fields readonly when under validation #860
• [16.0][IMP] configurable domain for readonly fields in validation #888
• [FIX] [16.0] base_tier_validation: Tier Validation Exceptions #902
• [16.0][FIX] base_tier_validation, base_export_manager, add sudo call to models without explicit access #921

BLACKLISTED (Already ported):

• [16.0][IMP] base_tier_validation: test performance improvement #778
• [16.0][FIX] base_tier_validation: Change web_ribbon text to title to make it translatable #813
• [FIX]base_tier_validation: Selection Field translated #830
• [16.0] [FIX] base_tier_validation: Wrong var name replacement #848

Verbose of OCA-PORT

1) PR #778 (https://github.com/OCA/server-ux/pull/778) [16.0][IMP] base_tier_validation: test performance improvement:
	By bosd, merged at 2023-11-30T07:24:36Z
	=> Not ported: base_tier_validation
	=> 1 commit(s) not (fully) ported

2) PR #802 (https://github.com/OCA/server-ux/pull/802) [16.0][PORT] 699 from 14.0: base_tier_validation multiple comment with approve_sequence_bypass:
	By bosd, merged at 2024-01-12T12:47:50Z
	=> Not ported: base_tier_validation
	=> 1 commit(s) not (fully) ported

3) PR #813 (https://github.com/OCA/server-ux/pull/813) [16.0][FIX] base_tier_validation: Change web_ribbon text to title to make it translatable:
	By victoralmau, merged at 2024-01-30T18:38:17Z
	=> Not ported: base_tier_validation
	=> 1 commit(s) not (fully) ported

4) PR #830 (https://github.com/OCA/server-ux/pull/830) [FIX]base_tier_validation: Selection Field translated:
	By bizzappdev, merged at 2024-03-07T09:59:50Z
	=> Not ported: base_tier_validation
	=> 1 commit(s) not (fully) ported

5) PR #848 (https://github.com/OCA/server-ux/pull/848) [16.0] [FIX] base_tier_validation: Wrong var name replacement:
	By manuelregidor, merged at 2024-03-22T09:52:23Z
	=> Not ported: base_tier_validation
	=> 1 commit(s) not (fully) ported

6) PR #860 (https://github.com/OCA/server-ux/pull/860) [16.0][ADD] base_tier_validation: set all form fields readonly when under validation:
	By hbrunn, merged at 2024-05-06T19:15:20Z
	=> Not ported: base_tier_validation
	=> 1 commit(s) not (fully) ported

7) PR #888 (https://github.com/OCA/server-ux/pull/888) [16.0][IMP] configurable domain for readonly fields in validation:
	By Kev-Roche, merged at 2024-06-19T12:47:58Z
	=> Not ported: base_tier_validation
	=> 1 commit(s) not (fully) ported

8) PR #902 (https://github.com/OCA/server-ux/pull/902) [FIX] [16.0] base_tier_validation: Tier Validation Exceptions:
	By Shide, merged at 2024-06-27T14:53:12Z
	=> Not ported: base_tier_validation
	=> 1 commit(s) not (fully) ported

MT-6609 @moduon @rafaelbn @LoisRForgeFlow @yajo please review if you want :)

[OCA-git-bot]

Hi @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

[LoisRForgeFlow]

@Shide Thanks! I will review this as soon as you think is ready

[Shide]

@LoisRForgeFlow ready! 😄

[LoisRForgeFlow]

View does not become readonly during validation and after validation as it happens in v16 with latest changes.

I'm testing locally with purchase_tier_validation

Am I missing something?

[LoisRForgeFlow]

Hi @Shide

I will be catching up in the latest proposal in v16 soon. In the meanwhile a friendly reminder here, have you had the chance to have a look?

It is importante that we align 16.0 and 17.0 so 16.0 features are not lost with the time and next migrations to 18.0 and next ones.

Thanks!

[Shide]

@LoisRForgeFlow I've fixed how readonly modifiers are built in Odoo 17

I've check the rest of the code and I doesn't find any usage of _get_tier_validation_readonly_domain to modify the return value

I'll port with cherrypick this PR too once it's merged #915

[Shide]

Also added #921

[LoisRForgeFlow]

Thanks, readonly looks great now. I found another issue though, when accessing with demo user and try to access the record under validation, I get the following error:

I would expect your last cherry pick to fix that, but it seems there is still something else.

[Shide]

@LoisRForgeFlow I can't replicate the error. What do you do?

[LoisRForgeFlow]

@Shide I tested again, and the problem seemed to be only in an old database that I had in local, I created a new database from scracth and the problem is not present anymore. So everything looks good to go now. Thanks!

[LoisRForgeFlow]

/ocabot merge major

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-905-by-LoisRForgeFlow-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at bbfa983. Thanks a lot for contributing to OCA. ❤️