Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] base_tier_validation_report: Migration to 16.0 #706

Merged
merged 6 commits into from
May 18, 2024
Merged

[16.0][MIG] base_tier_validation_report: Migration to 16.0 #706

merged 6 commits into from
May 18, 2024

Conversation

michaelslade54
Copy link
Contributor

Standard migration.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 10, 2023
@dreispt dreispt removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 28, 2023
bosd
bosd suggested changes Dec 28, 2023
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you re-trigger tests / runboat?

bosd
bosd reviewed Dec 28, 2023
View reviewed changes
base_tier_validation_report/reports/tier_review_report.xml
<field name="context">{}</field>
<field name="view_id" ref="tier_review_report_tree" />
<field name="search_view_id" ref="tier_review_report_search" />
<field
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

Any view with groups_id on it now has to move such groups to the elements of the view. But now you can put groups attribute in a view field instead of isolating it on a view without fear of an access error.

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 28, 2024
@dreispt
Copy link
Member

dreispt commented May 18, 2024

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-706-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 1af4324 into OCA:16.0 May 18, 2024
4 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a0e10b4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bosd bosd bosd requested changes

@dreispt dreispt dreispt approved these changes

Assignees
No one assigned
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@michaelslade54 @dreispt @OCA-git-bot @bosd @kittiu @ps-tubtim @jdidderen-noviat